Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create PR for normalizing files when validating #4305

Merged
merged 5 commits into from
Sep 20, 2024
Merged

Conversation

seanbudd
Copy link
Member

@seanbudd seanbudd commented Sep 19, 2024

Add-on files use a mixture of tabs and spaces. They also use a mix of unicode and ascii escape sequences of unicode characters e.g. \u1452.

Instead, when validating files, a PR should be opened to normalize these all to tabs and unicode.
Additionally jq code which was introducing these inconsistencies has been fixed up.

Successful run: https://github.com/nvaccess/addon-datastore/actions/runs/10935530692/job/30357445381
Successful PR: #4312

@seanbudd seanbudd marked this pull request as ready for review September 19, 2024 06:41
@seanbudd seanbudd changed the title Create PR for normalizing files Create PR for normalizing files when validating Sep 19, 2024
@seanbudd seanbudd merged commit 4dd1344 into master Sep 20, 2024
1 check failed
@seanbudd seanbudd deleted the normalizeAddons branch September 20, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants