minor fixups

nvaccess · Sep 6, 2024 · 78649c4 · 78649c4
1 parent 9245935
commit 78649c4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/.github/workflows/checkAddonUrlAndHash.js b/.github/workflows/checkAddonUrlAndHash.js
@@ -26,6 +26,7 @@ module.exports = ({core}, globPattern) => {
             return;
           }
         })
+        return;
       }
       // if hash mismatches, delete the file
       hash.setEncoding('hex');
@@ -39,12 +40,12 @@ module.exports = ({core}, globPattern) => {
           exec(`rm ${file}`, (err, stdout, stderr) => {
             if (stderr !== '' || err !== null) {
               console.log(`err: ${err}`);
-              console.log(`stdout: ${stdout}`);
               console.log(`stderr: ${stderr}`);
               core.setFailed('Failed to delete add-on file');
               return;
             }
           })
+          return;
         }
       })
     });

diff --git a/.github/workflows/validateAllAddons.yml b/.github/workflows/validateAllAddons.yml
@@ -42,7 +42,7 @@ jobs:
         git commit -m "Delete invalid downloads"
     - name: create PR for deleting invalid downloads
       if: always()
-      run: gh pr create -B master -H delInvalidDownloads${{ github.run_number }} --title 'Delete invalid add-ons' --body 'Delete add-ons with invalid download links or invalid file hashes'
+      run: gh pr create -B ${{ github.base_ref }} -H delInvalidDownloads${{ github.run_number }} --title 'Delete invalid add-ons' --body 'Delete add-ons with invalid download links or invalid file hashes'
       env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
     - name: Checkout validate repo