[CS2103T-W16-3] Fine$$e #83
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Upgrade Gradle using wrapper
The current version of Gradle used in this project is 5.2.1, while the latest version available is now 6.6.1.
An upgrade is needed to support additional plugins such as Pitest (which requires Gradle 5.6).
Let us use the Gradle wrapper to upgrade itself. The exact command used is:
gradlew wrapper --gradle-version=6.6.1 --distribution-type=bin
Gradle 6.6.1 release notes: https://docs.gradle.org/6.6.1/release-notes.html
* Fix deprecated property
Property archiveName is deprecated and will be removed from Gradle 7 onwards.
https://docs.gradle.org/6.6.1/dsl/org.gradle.api.tasks.bundling.AbstractArchiveTask.html#org.gradle.api.tasks.bundling.AbstractArchiveTask:archiveName
The deprecation warning message suggests using archiveFileName. Let us update the property from archiveName to archiveFileName to stay compliant with the future Gradle 7.
* Update information for Ian * Add team email
* Add Git pre-push hook * Remove redundant pre-push task Task 'test' is a subset of 'check'
* Update developer guide user stories, use cases * Edit grammar
* Update 'About Us' information for Siddarth * Update picture * Edit picture for 'About Us' page * Edit 'About Us' page Co-authored-by: Ian Yong <ianyongyc@gmail.com>
* Update 'About Us' information for Yong Ping * Delete johndoe.md and johndoe.png Co-authored-by: yongping827 <yongping827@users.noreply.github.com>
* Add NFR and Glossary in docs/DeveloperGuide.md * Unformat instances of glossary terms Co-authored-by: yongping827 <yongping827@users.noreply.github.com>
* Add layout for minutes * Add automatic meeting minutes index page * Add meeting minutes for 29 August 2020 * Add jekyll-spaceship * Update header links * Fix minutes formatting for 29 August 2020 * Add meeting minutes for 5 September 2020 * Add meeting minutes for 12 September 2020 * Add meeting minutes for 19 September 2020 * Remove trailing whitespace and add newline at EOF * Add CI job to build Jekyll without restrictions The default GitHub Pages build process enforces safe mode which disallows the use of any non-whitelisted dependencies. * Modify CI job to use 'GITHUB_TOKEN' instead * Add plugins used by GitHub pages These plugins were previously packaged under the 'github-pages' gem which had to be removed so as to remove the safe mode restrictions. * Disable jekyll-github-metadata * Add `baseurl` flag when building Jekyll * Fix minutes index page not using base URL * Fix some links missing a '/' This was achieved by prepending '/' before the repo name and using the resulting string as the base URL.
Criss-Wang
pushed a commit
to Criss-Wang/tp
that referenced
this pull request
Sep 25, 2020
* Run 'run-checks.sh' before pushing * Print status of formatting checks Also fix typo in 'check-trailing-whitespace.sh'
* Add 20200925 minutes * Add newline to end of file * Remove trailing whitespace
* Add Ui to README * Update index.md * Update root README.md * Update README.md to follow checkstyle * Update acknowledgements in README.md
* Rename classes * Edit coding style * Revert unnecessary edits * Refactor and update CLI syntax prefixes * Refactor methods and fields containing deprecated class names * Refactor parameter names, .fxml files * Revert changes in tutorials+diagrams, add import statement, DG typo Co-authored-by: yongping827 <yongping827@users.noreply.github.com> Co-authored-by: zhaojj2209 <zhaojj2000@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
============================================
- Coverage 72.31% 71.52% -0.79%
+ Complexity 400 387 -13
============================================
Files 70 69 -1
Lines 1228 1194 -34
Branches 124 117 -7
============================================
- Hits 888 854 -34
- Misses 308 309 +1
+ Partials 32 31 -1
Continue to review full report at Codecov.
|
* Add 2020-10-02 minutes * Remove trailing whitespace Co-authored-by: yongping827 <yongping827@users.noreply.github.com>
* Rename seedu.address * Fix docs, imports, whitespaces * Indentation
* Add AddIncomeCommand * Add ListIncomeCommand * Add unit tests * Fix Javadoc Co-authored-by: Ian Yong <ianyongyc@gmail.com> Co-authored-by: Ian Yong <ianyongyc@gmail.com>
* Add 'add-expense' command * Add 'ls-expense' command * Update Javadoc
* Rename 'name' field to 'title' * Update stray comment
* Add empty argument error checks * Fix empty title/category check for find command * Add error checks for concurrent use of amount/date and amount range/date range * Add tests * Minor edits, update tests
…eature (#291) * Abstract delete bookmark expense and income parsers * Abstract convert bookmark expense and income parsers * Add test for DeleteBookmarkCommand * Add tests for ConvertBookmarkCommand * Abstract edit bookmark expense and income parsers and add tests * Clean up code to adhere to checkstyle * Abstract out logic of parsing input arguments * Rename class names * Clean up code to adhere to checkstyle * Add tests for edit commands for bookmark income and bookmark expense * Clean up code to adhere to checkstyle * Refactor code for parsing BookmarkTransactionBuilder to ParserUtil * Rename class names and clean up code to adhere to checkstyle * Clean up code
* Prevent time from jumping backwards while application is active * Disable application upon TemporalException being thrown
* Make add expense/income commands switch to the respective tabs * Update user guide * Edit javadocs * Add tab switching to set expense limit/savings goal command, add tests * Update user guide * Refactor tests * Fix indentation, remove unused method
* Add MonthlyBudget tests * Remove traces of UndoCommand and RedoCommand from javadocs * Add more tests * Remove redundant field * Reduce code duplication
* Add unit tests for CalculatedAmount * Move assertion
* Remove duplicate BookmarkTransactionBuilder * Clean up code to adhere to checkstyle
* Rewrite MonthlyBudget calculations * Fix month overflow bug * Add comments to describe logic
* Update developer guide for model and find feature * Update developer guide for budget feature * Update diagrams * Remove files * Update user stories * Add manual testing * Add manual testing for bookmark transactions * Fix formatting and grammar
* Differentiate transactions on overview tab * Make red lighter * Update Javadoc * Consolidate constuctors * Update user guide
* Modify ParserUtil.parseBookmarkTransactionBuilder to parse all possible prefixes * Move TransactionBuilder into main package * Add ParserUtil::parseTransactionBuilder method * Add tests for ParserUtil::parseTransactionBuilder method * Reorder imports * Modify ArgumentTokenizer::tokenize * Remove unused imports * Edit Javadocs * Modify ArgumentTokenizer::tokenize to display present invalid prefixes * Add string constant MESSAGE_INVALID_PREFIX_PRESENT_HEADER * Update tests * Update Javadocs * Update user guide * Bring up coverage * Remove unused imports * Update tests * Reorder imports * Rephrase error message
* Add Analytics section * Add object diagram * Add newline at EOF * Edit Analytics feature section * Remove trailing whitespace * Adjust header levels
* Add documentation for add/edit transactions feature in DG * Add documentation for delete transactions feature in DG * Add use cases for income * Update AddTransactionClassDiagram.png
* Standardise automatic tab switching messages * Add list of commands which programmatically switch tabs * Make actor black * Update tab switching and model * Add command history * Add data integrity safeguards * Add newline at EOF * Update design considerations * Update UiClassDiagram
* Update acknowledgements * Update links * Remove unused libraries
* Update developer guide * Add use cases for bookmark transaction feature * Add use cases to developer guide * Remove trailing whitespace * Remove remaining trailing whitespace * Add newline at EOF for puml * Remove trailing whitespace * Add class diagram for add bookmark transactions feature * Update acitvity diagram * Update Gemile.lock
* Update PPP * Add reviewed PRs
* Update screenshots in UG * Update screenshot of Overview Tab * Add remaining screenshots * Remove trailing whitespace
* Update use cases, update image * Finalise developer guide * Edit use cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fine$$e allows tertiary students to better manage their finances, cultivating good financial habits such as saving. It is optimised for CLI users so that expenses and income can be tracked efficiently by typing in commands.