[CS2103T-T17-2] Traveez #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alages97
added a commit
to alages97/main
that referenced
this pull request
Oct 22, 2019
v1.2 v1.3 Increments
EugeneTeu
reviewed
Oct 24, 2019
| @@ -93,13 +107,14 @@ The `UI` component, | |||
|
|
|||
| [[fig-LogicClassDiagram]] | |||
| .Structure of the Logic Component | |||
| image::LogicClassDiagram.png[] | |||
| image::BetterLogicClassDiagram.png[] | |||
There was a problem hiding this comment.
Can break up into smaller abstraction
| @@ -115,21 +130,23 @@ NOTE: The lifeline for `DeleteCommandParser` should end at the destroy marker (X | |||
| === Model component | |||
|
|
|||
| .Structure of the Model Component | |||
| image::ModelClassDiagram.png[] | |||
| image::BetterModelClassDiagram.png[] | |||
There was a problem hiding this comment.
There should not be floating models in the diagrams. need an arrow to bind it to something
docs/DeveloperGuide.adoc
Outdated
|
|
||
| *Calendar Class Diagram:*+ | ||
|
|
||
| image::CalendarClassDiagram.png[] |
There was a problem hiding this comment.
Calendar should not have an extra arrow to abstract class events.
Calendar can be placed below ReadOnlyCalendar to improve readability
docs/DeveloperGuide.adoc
Outdated
|
|
||
| The above diagram shows that ``Calendar`` stores information about the state of the user's calendar, including information about the user's current view as indicated by ``currentMonth``. | ||
|
|
||
| image::ShowSequenceDiagram.png[] |
There was a problem hiding this comment.
is the last Command Result box missing an arrow back to Logic manager?
docs/DeveloperGuide.adoc
Outdated
| exposes an unmodifiable ObservableList<Event> that can be 'observed' e.g. the UI can be bound to this list so that | ||
| the UI automatically updates when the data in the list change. | ||
|
|
||
| does not depend on any of the other three components, UI, logic and storage which are common through all the features |
|
|
||
| === Model Component | ||
|
|
||
| The implementation of the model class in TravEzy is to be a generic. Hence, the model object being instantiated |
There was a problem hiding this comment.
If I am not wrong, you guys are treating model as a data type here right?
Updates UG Main images
Update UG - Diary
Update UG for main
* 'master' of https://github.com/AY1920S1-CS2103T-T17-2/main: (27 commits) Update UserGuide.adoc Update UserGuide.adoc Update UserGuide.adoc Update UserGuide.adoc Update UserGuide.adoc Update UserGuide.adoc Updates UG main checkstyle Update UserGuide.adoc Update UserGuide.adoc Updates UG Add files via upload Update UserGuide.adoc Add files via upload Add files via upload Delete check1.png Delete check2.png Update UserGuide.adoc Update UserGuide.adoc Update UserGuide.adoc ... # Conflicts: # docs/UserGuide.adoc
Solve merge conflicts and update UG
Revert "Solve merge conflicts and update UG"
# Conflicts: # docs/DeveloperGuide.adoc
Refine DG
Calendar v1.4
Fix checkstyle
Merge fixes
* 'master' of https://github.com/AY1920S1-CS2103T-T17-2/main: Fix developer guides and user guides Fix website Fix checkstyle Fix checkstyle Fix checkstyle Update Developer Guide Fix checkstyle v1.4 implementation
Calendar v1.4
Update UserGuide.adoc
Update bjhoohaha.adoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.