Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CS2103T-T10-3] ELISA #133

Open
wants to merge 1,190 commits into
base: master
Choose a base branch
from

Conversation

blimyj
Copy link

@blimyj blimyj commented Oct 4, 2019

No description provided.

@arjunwangty
Copy link

3.1.1 Step one - The diagrams should follow UML notation, maybe it would be better to include less details about the algorithm and focus more on the interaction between classes and execution of the program.

3.3.2 More diagrams could be used to make the explanation clearer. Sequence diagram is clean and detailed.

Copy link

@keiteo keiteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Some comments:

  • Remember to update AB3 diagrams if you renamed classes e.g. ABParser > ElisaParser
  • Might want to add design considerations for some of the sections
  • Resize diagrams so that the text size is consistent across the document


*API* :
link:{repoURL}/src/main/java/seedu/address/logic/Logic.java[`Logic.java`]

. `Logic` uses the `AddressBookParser` class to parse the user command.
. `Logic` uses the `ElisaParser` class to parse the user command.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to update the AddressBookParser names in subsequent diagrams

Comment on lines 177 to 179
Step 1. The user executes `task eat`. A task with description "eat" is added and then the command is pushed into the commands stack.

image::UndoStackStep1.png[]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you could label AddTaskCommand in the model to reflect task eat command in step 1. Perhaps the image could be resized so that the text size is consistent with the DG.

@@ -153,6 +158,33 @@ Classes used by multiple components are in the `seedu.addressbook.commons` packa

This section describes some noteworthy details on how certain features are implemented.

// tag::undobyreverse[]
=== [Implemented] Undo Feature
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to remove the AB3 undo future implementation section

sianghwee and others added 30 commits November 11, 2019 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants