Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add actionlint #146

Merged
merged 1 commit into from
Jul 9, 2024
Merged

add actionlint #146

merged 1 commit into from
Jul 9, 2024

Conversation

katexochen
Copy link
Contributor

@katexochen katexochen commented Jan 5, 2024

I would like to add actionlint (which is more a linter than a formatter, but I saw that shellcheck seems to be okay, so actionlint should fit, too).

However, I'm facing some problems with the include statements. For some reason, files in the .github directory are not included/linted.

I have provided a test commit that activates actionlint and includes two files that should throw errors, one in .github, the other in github. Running nix fmt, this will only print errors for the non-hidden dir.

@zimbatm is treefmt in general not capable of formatting hidden files?

@katexochen
Copy link
Contributor Author

I found numtide/treefmt#153

@zimbatm
Copy link
Member

zimbatm commented May 30, 2024

this is better handled by treefmt2, since it can now use git ls-files as a backend

@katexochen
Copy link
Contributor Author

this is better handled by treefmt2, since it can now use git ls-files as a backend

Nice, looking forward to v2. :)

@Mic92
Copy link
Member

Mic92 commented Jun 30, 2024

v2 was released.

@zimbatm
Copy link
Member

zimbatm commented Jun 30, 2024

Waiting for nixos-unstable to become available: https://nixpk.gs/pr-tracker.html?pr=323172

@Mic92
Copy link
Member

Mic92 commented Jul 1, 2024

This now also happened.

@katexochen
Copy link
Contributor Author

see #192 :)

Signed-off-by: Paul Meyer <49727155+katexochen@users.noreply.github.com>
@katexochen katexochen marked this pull request as ready for review July 2, 2024 18:26
@zimbatm zimbatm merged commit 8b63fe8 into numtide:main Jul 9, 2024
217 of 242 checks passed
@katexochen katexochen deleted the actionlint/init branch July 9, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants