Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall back to discontinous reads of discrete outputs #31

Draft
wants to merge 1 commit into
base: sim-exceptions
Choose a base branch
from

Conversation

alexrudd2
Copy link
Member

I'm not sure of my approach here, hence the separate branch.

This more or less works, although in my case trying to read ~180 tags sequentially takes >1 s and so the regular controller read() loop timesout unless I slow it down. It also generates a lot of logging if you have many broken writes! Would it be smarter to stop polling addresses with some sort of blacklist if they return an exception?

Also, this error was introduced but doesn't appear to affect anything?

ERROR:pymodbus.client.asynchronous.asyncio:Factory protocol connect callback called while connected.

@alexrudd2 alexrudd2 marked this pull request as draft February 9, 2021 20:49
@alexrudd2
Copy link
Member Author

Interesting, apparently we can now do drafts for public repos, but not private?!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant