[WIP] fix: wait for hydration via react effect #319
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to reduce the flakiness of the tests as much as possible. But it isn't perfect: sometimes the page hydration just fails for unknown reasons, especially on Windows. The new
isReady
check tries to recover from hydration fails, by reloading the page, which seems to work pretty solidly. Longterm though we should think about rewriting a lot of the tests, especially those related to HMR &fixture.updateFile
.I ran the updated tests countless times with force-pushes and so far got zero fails with the latest version.