Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix manifest plugin, collect-styles.js node resolution #27

Merged

Conversation

JesseVelden
Copy link
Contributor

@JesseVelden JesseVelden commented Dec 18, 2023

This Pull Request is fixing the node resolution inside collect-styles.js, as it currently gives error messages for transformed imports in certain cases, so it can fix #26.

Copy link

codesandbox bot commented Dec 18, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

vercel bot commented Dec 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vinxi-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2023 4:05pm

@nksaraf nksaraf merged commit 291d8f5 into nksaraf:main Dec 20, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

manifest plugin doesn't work with unplugin-icons
2 participants