Fix rule identifiers #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… rule name breaks rules whose names don't match their identifiers.
…made in the organization-level rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changes to our scripts made the distinction between a rule's name and its identifier when parsing documentation. For example, the identifier for the
multi-region-cloudtrail-enabledrule isMULTI_REGION_CLOUD_TRAIL_ENABLED, so simply lowercasing and replacing_with-doesn't result in the other and vice versa.This PR explicitly adds the rule's identifier to the JSON file generated after parsing documentation, and that identifier is then explicitly referenced in Terraform config instead of transforming the rule name. This should resolve issues like this when applying Terraform: