1226 create showcase app #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newmanw
requested changes
Sep 27, 2024
plugins/arcgis/web-app/projects/main/src/lib/arc-event/arc-event.component.ts
Show resolved
Hide resolved
plugins/arcgis/web-app/projects/main/src/lib/arc.service.mock.ts
Outdated
Show resolved
Hide resolved
plugins/arcgis/web-app/projects/showcase/src/app/app.component.scss
Outdated
Show resolved
Hide resolved
newmanw
reviewed
Sep 27, 2024
…d removed changes made to the arc-event component.
The only thing i added to the plugin code was the typescript interface that the main service and the mock service (now in the showcase) implement. Everything else should be removed at this point. |
newmanw
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a "showcase" angular application that allows users to quicky spin up the UI of the ArcGIS plugin within mage server