Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arcgis username and password authentication #216

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Conversation

Skosche3
Copy link
Contributor

Provides draft for peer review for adding username/password authentication with ArcGIS server.

Things to possibly do yet

  1. Update UI webapp to provide username/password options or token with url, remove hardcoded section for testing
  2. Testing and handle use cases beyond happy path
  3. Move getServerUrl to Helper file
  4. Move getPortalUrl to Helper file
  5. Update layer token to get token from identity manager
  6. Move plugins/arcgis/web-app/projects/main/src/lib/arc-layer/arc-layer.component.ts addLayer to helper file and use instead of encodeURIComponent
  7. Provide ability to refresh token upon expiration (if needed)
  8. Any remaining TODOs

@newmanw newmanw self-assigned this Sep 25, 2024
@newmanw newmanw marked this pull request as ready for review September 25, 2024 17:52
Copy link
Member

@newmanw newmanw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple comments here we can look at as we proceed, nothing holding up this PR>

@ryanslatten
Copy link
Contributor

Looks like you have some merge errors

@newmanw newmanw merged commit d4901e8 into develop Sep 26, 2024
13 of 19 checks passed
@newmanw newmanw deleted the arcgis-authentication branch September 26, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants