chore: upgrade react-aria #3732
Conversation
🦋 Changeset detectedLatest commit: 6ae723e The changes in this PR will be included in the next version bump. This PR includes changesets to release 53 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThis pull request introduces a series of updates across various components of the NextUI library, primarily focusing on dependency version increments for packages related to React Aria and React Stately. It includes minor version updates for the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Component
participant Library
User->>Component: Interact with UI
Component->>Library: Call updated methods
Library-->>Component: Return results
Component-->>User: Update UI based on results
Suggested labels
Tip New featuresWalkthrough comment now includes:
Notes:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| // @ts-expect-error autoCapitalize is not a valid prop | ||
| // Removing autoCapitalize as it causes bugs in Firefox. | ||
| // See: https://github.com/adobe/react-spectrum/issues/5599 | ||
| delete segmentProps.autoCapitalize; |
There was a problem hiding this comment.
Since the autoCapitalize prop has been removed, I also removed this process.
adobe/react-spectrum#6657
| @@ -40,22 +40,22 @@ | |||
| "react-dom": ">=18" | |||
| }, | |||
| "dependencies": { | |||
| "@internationalized/date": "^3.5.4", | |||
| "@internationalized/date": "3.5.5", | |||
There was a problem hiding this comment.
The type of DateValue is different between 3.5.4 and 3.5.5, so I have fixed it to 3.5.5.
adobe/react-spectrum#6076
| @@ -49,9 +49,9 @@ export function CalendarCell(originalProps: CalendarCellProps) { | |||
| !isDisabled && !isInvalid && state.isCellUnavailable(props.date.subtract({days: 1})); | |||
| const highlightedRange = "highlightedRange" in state && state.highlightedRange; | |||
| const isSelectionStart = | |||
| isSelected && highlightedRange && isSameDay(props.date, highlightedRange.start); | |||
| isSelected && highlightedRange ? isSameDay(props.date, highlightedRange.start) : false; | |||
There was a problem hiding this comment.
Due to the type change, highlightedRange can be null.
adobe/react-spectrum#6076
| const {layout, ...otherOriginalProps} = originalProps; | ||
| const {gridProps} = useReactAriaTable<T>({...otherOriginalProps}, state, domRef); |
There was a problem hiding this comment.
layout (layoutNode) has been deprecated, so I'm not passing it. If needed, you can use layoutDelegate instead. This is a breaking change, but since the layoutNode prop is quite a specific use case, I don't think it will be a major issue.
adobe/react-spectrum#6518
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
Files selected for processing (59)
- .changeset/few-jars-flow.md (1 hunks)
- apps/docs/package.json (2 hunks)
- package.json (1 hunks)
- packages/components/accordion/package.json (1 hunks)
- packages/components/autocomplete/package.json (2 hunks)
- packages/components/avatar/package.json (1 hunks)
- packages/components/breadcrumbs/package.json (1 hunks)
- packages/components/button/package.json (1 hunks)
- packages/components/calendar/package.json (1 hunks)
- packages/components/calendar/src/calendar-cell.tsx (1 hunks)
- packages/components/calendar/src/utils.ts (1 hunks)
- packages/components/card/package.json (1 hunks)
- packages/components/checkbox/package.json (1 hunks)
- packages/components/chip/package.json (1 hunks)
- packages/components/date-input/package.json (1 hunks)
- packages/components/date-input/src/date-input-segment.tsx (1 hunks)
- packages/components/date-input/src/use-date-input.ts (1 hunks)
- packages/components/date-picker/package.json (1 hunks)
- packages/components/divider/package.json (1 hunks)
- packages/components/dropdown/package.json (1 hunks)
- packages/components/input/package.json (1 hunks)
- packages/components/input/src/use-input.ts (2 hunks)
- packages/components/kbd/package.json (1 hunks)
- packages/components/link/package.json (1 hunks)
- packages/components/listbox/package.json (1 hunks)
- packages/components/menu/package.json (1 hunks)
- packages/components/modal/package.json (1 hunks)
- packages/components/navbar/package.json (1 hunks)
- packages/components/pagination/package.json (1 hunks)
- packages/components/popover/package.json (1 hunks)
- packages/components/progress/package.json (1 hunks)
- packages/components/radio/package.json (1 hunks)
- packages/components/select/package.json (2 hunks)
- packages/components/slider/package.json (1 hunks)
- packages/components/snippet/package.json (1 hunks)
- packages/components/switch/package.json (1 hunks)
- packages/components/table/package.json (2 hunks)
- packages/components/table/src/use-table.ts (3 hunks)
- packages/components/tabs/package.json (1 hunks)
- packages/components/tooltip/package.json (1 hunks)
- packages/components/user/package.json (1 hunks)
- packages/core/react/package.json (1 hunks)
- packages/core/system-rsc/package.json (1 hunks)
- packages/core/system/package.json (2 hunks)
- packages/core/system/src/provider-context.ts (2 hunks)
- packages/hooks/use-aria-accordion-item/package.json (1 hunks)
- packages/hooks/use-aria-accordion/package.json (1 hunks)
- packages/hooks/use-aria-button/package.json (1 hunks)
- packages/hooks/use-aria-link/package.json (1 hunks)
- packages/hooks/use-aria-menu/package.json (1 hunks)
- packages/hooks/use-aria-modal-overlay/package.json (1 hunks)
- packages/hooks/use-aria-multiselect/package.json (1 hunks)
- packages/hooks/use-aria-overlay/package.json (1 hunks)
- packages/hooks/use-aria-toggle-button/package.json (1 hunks)
- packages/hooks/use-disclosure/package.json (1 hunks)
- packages/hooks/use-intersection-observer/package.json (1 hunks)
- packages/hooks/use-is-mobile/package.json (1 hunks)
- packages/hooks/use-pagination/package.json (1 hunks)
- packages/utilities/aria-utils/package.json (1 hunks)
Files not reviewed due to server errors (1)
- packages/components/select/package.json
Files skipped from review due to trivial changes (28)
- apps/docs/package.json
- packages/components/accordion/package.json
- packages/components/autocomplete/package.json
- packages/components/avatar/package.json
- packages/components/breadcrumbs/package.json
- packages/components/calendar/package.json
- packages/components/checkbox/package.json
- packages/components/date-input/src/date-input-segment.tsx
- packages/components/dropdown/package.json
- packages/components/input/src/use-input.ts
- packages/components/listbox/package.json
- packages/components/navbar/package.json
- packages/components/popover/package.json
- packages/components/progress/package.json
- packages/components/snippet/package.json
- packages/components/switch/package.json
- packages/components/tooltip/package.json
- packages/components/user/package.json
- packages/core/react/package.json
- packages/core/system-rsc/package.json
- packages/hooks/use-aria-accordion-item/package.json
- packages/hooks/use-aria-menu/package.json
- packages/hooks/use-aria-overlay/package.json
- packages/hooks/use-aria-toggle-button/package.json
- packages/hooks/use-disclosure/package.json
- packages/hooks/use-intersection-observer/package.json
- packages/hooks/use-is-mobile/package.json
- packages/utilities/aria-utils/package.json
Additional comments not posted (103)
packages/hooks/use-pagination/package.json (1)
38-38: Approved dependency update for@react-aria/i18n.Updating the
@react-aria/i18ndependency to version3.12.2is crucial for keeping the library up-to-date. Ensure to verify that this update integrates well with the existing codebase and does not introduce any breaking changes.Run the following script to verify the integration of the updated dependency:
Verification successful
Dependency Update Verified for
@react-aria/i18nThe update to version
3.12.2of the@react-aria/i18ndependency has been successfully integrated across the codebase. The usage of this package in various components and hooks shows no immediate issues or errors. The update appears to be consistent and without breaking changes.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the integration of the updated dependency. # Test: Search for any issues related to the updated dependency version. rg --type json -A 5 $'@react-aria/i18n'Length of output: 5855
Script:
#!/bin/bash # Search for usage of @react-aria/i18n in the codebase to verify integration. rg '@react-aria/i18n' -A 5Length of output: 68256
packages/components/divider/package.json (1)
45-45: Approved dependency update for@react-types/shared.Updating the
@react-types/shareddependency to version3.24.1is crucial for keeping the library up-to-date. Ensure to verify that this update integrates well with the existing codebase and does not introduce any breaking changes.Run the following script to verify the integration of the updated dependency:
packages/components/kbd/package.json (1)
45-45: Version update approved for@react-aria/utils.The update from
3.24.1to3.25.2is noted. Please ensure to verify the specific changes between these versions for any potential breaking changes or new features that might affect the package's functionality.packages/hooks/use-aria-link/package.json (1)
40-43: Version updates approved for React Aria dependencies.The updates to
@react-aria/focus,@react-aria/interactions,@react-aria/utils, and@react-types/linkare noted. Please ensure to verify the specific changes between these versions for any potential breaking changes or new features that might affect the package's functionality.packages/hooks/use-aria-button/package.json (1)
40-44: Version updates approved for React Aria dependencies.The updates to
@react-aria/focus,@react-aria/interactions,@react-aria/utils, and@react-types/buttonare noted. Please ensure to verify the specific changes between these versions for any potential breaking changes or new features that might affect the package's functionality.packages/hooks/use-aria-accordion/package.json (6)
37-37: Dependency update approved for@react-aria/button.The update from
3.9.5to3.9.8is approved. However, ensure to verify through integration tests that the update integrates well with existing code.
38-38: Dependency update approved for@react-aria/focus.The update from
3.17.1to3.18.2is approved. It's crucial to verify that focus management features continue to function as expected across the application.
39-39: Dependency update approved for@react-aria/selection.The update from
3.18.1to3.19.3is approved. Ensure to conduct thorough testing on selection features within the accordion to confirm that they operate correctly.
40-40: Dependency update approved for@react-aria/utils.The update from
3.24.1to3.25.2is approved. Given the broad impact of utility functions, a comprehensive review of their usage across the project is recommended to ensure compatibility.
41-41: Dependency update approved for@react-stately/tree.The update from
3.8.1to3.8.4is approved. Verify that state management for tree structures within the accordion remains stable and functional.
42-42: Dependency update approved for@react-types/accordion.The update from
3.0.0-alpha.21to3.0.0-alpha.23is approved. Given the experimental nature of alpha versions, extensive testing is recommended to ensure that the types align with the accordion's functionality.packages/core/system/package.json (6)
37-37: Approved the addition offramer-motiontopeerDependencies.This change helps avoid version conflicts by allowing consumers to specify their own version of
framer-motion. Ensure that this change is communicated clearly in the project's documentation to inform users.
57-57: Approved the addition of@internationalized/date.This addition suggests new date handling functionalities. Ensure that this new dependency integrates well with the existing codebase and does not introduce any compatibility issues.
Verification successful
Integration of
@internationalized/dateis successful and well-utilized.The
@internationalized/datepackage is extensively used across various components and applications, confirming its integration and necessity for date-related functionalities in the project. No issues were found with its usage.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the integration of `@internationalized/date` in the project. # Test: Search for the usage of `@internationalized/date` in the project. rg --type json -A 5 $'@internationalized/date'Length of output: 2381
Script:
#!/bin/bash # Description: Verify the usage of `@internationalized/date` in the codebase. # Test: Search for import statements or references to `@internationalized/date` in JavaScript or TypeScript files. rg --type js --type ts '@internationalized/date'Length of output: 16783
63-63: Approved the update of@react-stately/utils.This minor version update is likely to include small bug fixes or performance improvements. Verify that this update integrates well with the existing stately functionalities and does not introduce any regressions.
Verification successful
Approved the update of
@react-stately/utils.The update to version
3.10.3appears to be part of a broader upgrade effort, and no issues have been reported. However, it is recommended to conduct manual testing to ensure that the update integrates well with the existing functionalities and does not introduce any regressions.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the impact of the updated `@react-stately/utils` on stately functionalities. # Test: Search for the usage of `@react-stately/utils` and check for potential issues. rg --type json -A 5 $'@react-stately/utils'Length of output: 2438
Script:
#!/bin/bash # Check the commit history for recent changes related to `@react-stately/utils`. git log -n 10 -- packages/core/system/package.json # Look for any open issues or discussions regarding the update to `3.10.3`. gh issue list --search "@react-stately/utils 3.10.3"Length of output: 959
61-61: Approved the update of@react-aria/overlays.This version update is expected to include improvements or bug fixes related to overlays. Verify that this update integrates well with the existing overlay functionalities and does not introduce any regressions.
60-60: Approved the update of@react-aria/i18n.This version update is likely to include important bug fixes or new features. Verify that this update integrates well with the existing i18n functionalities and does not introduce any regressions.
62-62: Approved the update of@react-aria/utils.This version update is expected to include general utility improvements or bug fixes. Verify that this update integrates well with the existing utility functionalities and does not introduce any regressions.
.changeset/few-jars-flow.md (1)
1-53: Comprehensive and well-documented changeset.The changeset file
.changeset/few-jars-flow.mdeffectively documents the version updates for various components within the NextUI library. Each package update is clearly listed with the type of version change (minor or patch), which aligns with the PR's objectives to update dependencies systematically.packages/components/radio/package.json (1)
45-52: Dependency updates are correctly specified.The updates to the dependencies in the
package.jsonfor the radio component are correctly specified. Each library related to React Aria and React Stately has been updated to a newer version, which should help in incorporating the latest bug fixes and performance improvements.packages/components/date-input/package.json (1)
45-51: Dependency updates are correctly specified and aligned with PR objectives.The updates to the dependencies in the
package.jsonfor the date-input component are correctly specified. Each library related to date handling and accessibility has been updated to a newer version, which aligns with the PR's objectives to enhance functionality and fix bugs.packages/components/slider/package.json (7)
46-46: Dependency update approved for@react-aria/focus.Ensure to review the release notes for
@react-aria/focusversion3.18.2to understand the changes and verify their impact on the slider component.
47-47: Dependency update approved for@react-aria/i18n.Ensure to review the release notes for
@react-aria/i18nversion3.12.2to understand the changes and verify their impact on the slider component.
48-48: Dependency update approved for@react-aria/interactions.Ensure to review the release notes for
@react-aria/interactionsversion3.22.2to understand the changes and verify their impact on the slider component.
49-49: Dependency update approved for@react-aria/slider.Ensure to review the release notes for
@react-aria/sliderversion3.7.11to understand the changes and verify their impact on the slider component.
50-50: Dependency update approved for@react-aria/utils.Ensure to review the release notes for
@react-aria/utilsversion3.25.2to understand the changes and verify their impact on the slider component.
51-51: Dependency update approved for@react-aria/visually-hidden.Ensure to review the release notes for
@react-aria/visually-hiddenversion3.8.15to understand the changes and verify their impact on the slider component.
52-52: Dependency update approved for@react-stately/slider.Ensure to review the release notes for
@react-stately/sliderversion3.5.7to understand the changes and verify their impact on the slider component.packages/hooks/use-aria-multiselect/package.json (14)
38-38: Dependency update approved for@react-aria/interactions.The update from
3.21.3to3.22.2is approved. It's crucial to verify the release notes for any changes that might affect interaction patterns or introduce new features.
46-46: Dependency update approved for@react-stately/menu.The update from
3.7.1to3.8.2is approved. It's crucial to verify the release notes for any changes that might affect menu behavior or introduce new accessibility features.
43-43: Dependency update approved for@react-aria/utils.The update from
3.24.1to3.25.2is approved. It's crucial to verify the release notes for any changes that might affect utility functions or introduce new accessibility features.
45-45: Dependency update approved for@react-stately/list.The update from
3.10.5to3.10.8is approved. Patch updates usually include bug fixes or minor improvements. Ensure to review the release notes for any critical fixes that might be essential for the package's functionality.
39-39: Dependency update approved for@react-aria/label.The update from
3.7.8to3.7.11is approved. Patch updates usually include bug fixes or minor improvements. Ensure to review the release notes for any critical fixes that might be essential for the package's functionality.
48-48: Dependency update approved for@react-types/overlays.The update from
3.8.7to3.8.9is approved. It's crucial to verify the release notes for any changes that might affect overlays types or introduce new accessibility features.
44-44: Dependency update approved for@react-stately/form.The update from
3.0.3to3.0.5is approved. Patch updates usually include bug fixes or minor improvements. Ensure to review the release notes for any critical fixes that might be essential for the package's functionality.
37-37: Dependency update approved for@react-aria/i18n.The update from
3.11.1to3.12.2is approved. However, ensure to review the release notes for any breaking changes or major updates that could impact the package's functionality.
49-49: Dependency update approved for@react-types/select.The update from
3.9.4to3.9.6is approved. It's crucial to verify the release notes for any changes that might affect select types or introduce new accessibility features.
50-50: Dependency update approved for@react-types/shared.The update from
3.23.1to3.24.1is approved. It's crucial to verify the release notes for any changes that might affect shared types or introduce new accessibility features.
42-42: Dependency update approved for@react-aria/selection.The update from
3.18.1to3.19.3is approved. It's crucial to verify the release notes for any changes that might affect selection behavior or introduce new accessibility features.
47-47: Dependency update approved for@react-types/button.The update from
3.9.4to3.9.6is approved. It's crucial to verify the release notes for any changes that might affect button types or introduce new accessibility features.
40-40: Dependency update approved for@react-aria/listbox.The update from
3.12.1to3.13.3is approved. It's crucial to verify the release notes for any changes that might affect listbox behavior or introduce new accessibility features.
41-41: Dependency update approved for@react-aria/menu.The update from
3.14.1to3.15.3is approved. It's crucial to verify the release notes for any changes that might affect menu behavior or introduce new accessibility features.packages/components/date-picker/package.json (2)
43-43: Dependency version fixed for@internationalized/date.The version has been updated from
^3.5.4to3.5.5to address a type change issue as noted in a previous comment by ryo-manba. This change ensures that the component uses the correct type definitions.
51-58: Updated React Aria and Stately dependencies.The updates to
@react-aria/datepicker,@react-aria/i18n,@react-aria/utils,@react-stately/datepicker,@react-stately/overlays,@react-stately/utils,@react-types/datepicker, and@react-types/sharedare all minor and patch updates. These updates are likely to include bug fixes, performance improvements, and compatibility with newer versions of React. It's important to ensure that these updates do not introduce any breaking changes or regressions.packages/components/modal/package.json (1)
51-57: Updated React Aria and Stately dependencies for modal component.The updates to
@react-aria/dialog,@react-aria/focus,@react-aria/interactions,@react-aria/overlays,@react-aria/utils,@react-stately/overlays, and@react-types/overlaysare all minor and patch updates. These updates are likely to include bug fixes and performance improvements. It's important to ensure that these updates do not introduce any breaking changes or regressions.packages/components/tabs/package.json (1)
50-56: Updated React Aria and Stately dependencies for tabs component.The updates to
@react-aria/focus,@react-aria/interactions,@react-aria/tabs,@react-aria/utils,@react-stately/tabs,@react-types/shared, and@react-types/tabsare all minor and patch updates. These updates are likely to include bug fixes and performance improvements. It's important to ensure that these updates do not introduce any breaking changes or regressions.packages/components/table/package.json (10)
48-48: Dependency update approved for@react-aria/focus.The update from
3.17.1to3.18.2is a minor version change, typically involving enhancements or bug fixes without breaking existing functionality.
49-49: Dependency update approved for@react-aria/interactions.The update from
3.21.3to3.22.2is a minor version change, likely including improvements or bug fixes that do not introduce breaking changes.
50-50: Dependency update approved for@react-aria/table.The update from
3.14.1to3.15.3is a minor version change, typically involving enhancements or bug fixes without breaking existing functionality.
51-51: Dependency update approved for@react-aria/utils.The update from
3.24.1to3.25.2is a minor version change, likely including improvements or bug fixes that do not introduce breaking changes.
52-52: Dependency update approved for@react-aria/visually-hidden.The update from
3.8.12to3.8.15is a patch version change, typically involving minor bug fixes or optimizations.
53-53: Dependency update approved for@react-stately/table.The update from
3.11.8to3.12.2is a minor version change, likely including improvements or bug fixes that do not introduce breaking changes.
55-55: Dependency update approved for@react-types/grid.The update from
3.2.6to3.2.8is a minor version change, typically involving enhancements or bug fixes without breaking existing functionality.
56-56: Dependency update approved for@react-types/table.The update from
3.9.5to3.10.1is a minor version change, typically involving enhancements or bug fixes without breaking existing functionality.
68-68: Dependency update approved for@react-stately/data.The update from
3.11.4to3.11.6is a minor version change, likely including improvements or bug fixes that do not introduce breaking changes.
54-54: Verify the impact of the major version update for@react-stately/virtualizer.The update from
3.7.1to4.0.2is a major version change. It is crucial to verify that this update does not introduce any breaking changes or regressions in the functionality of the components relying on this library.packages/components/calendar/src/calendar-cell.tsx (1)
52-54: Refinement in selection logic enhances clarity and correctness.The update to use ternary operators for
isSelectionStartandisSelectionEndensures that these values are explicitly set tofalsewhen conditions are not met, which prevents any unintended truthy evaluations. This change enhances both the clarity and correctness of the selection logic.package.json (1)
71-71: Version update approved for@react-types/shared.The update from
3.23.1to3.24.1for the@react-types/sharedpackage is approved. It's important to ensure that this update does not introduce compatibility issues with other packages that depend on it.Run the following script to verify compatibility with other packages:
packages/components/table/src/use-table.ts (1)
126-126: Refinement inuseTableprops handling enhances API clarity.The exclusion of the
layoutproperty fromAriaTablePropsand the removal oflayoutNodefrom the destructured properties reflect a deliberate refinement in the API. These changes enhance clarity and ensure that deprecated or conflicting properties do not interfere with the functionality of the table component.Also applies to: 190-193
packages/components/date-input/src/use-date-input.ts (2)
5-5: Import retention approved.The retention of the
Calendarimport from@internationalized/dateis approved as it supports existing functionality related to custom calendar implementations within the component.
4-4: Verify type compatibility after import change.The import of
DateValuehas been changed to align with the updatedreact-arialibrary. While this change is approved, it's crucial to verify that the new type definition from@react-types/datepickeris compatible with the existing usage in this component.Run the following script to verify the type compatibility:
packages/hooks/use-aria-modal-overlay/package.json (3)
38-38: Dependency version updated for@react-aria/overlays.The version has been updated from
3.22.1to3.23.2. Ensure that this update is compatible with other parts of the project and check for any breaking changes in the release notes.
39-39: Dependency version updated for@react-aria/utils.The version has been updated from
3.24.1to3.25.2. It's crucial to verify that this update integrates well with the project, especially since@react-aria/utilsoften includes utility functions that might affect various components.
40-40: Dependency version updated for@react-stately/overlays.The version has been updated from
3.6.7to3.6.10. Check the release notes for any significant changes that might impact the project's stability or functionality.packages/components/chip/package.json (4)
46-46: Dependency version updated for@react-aria/focus.The version has been updated from
3.17.1to3.18.2. Ensure that this update is compatible with other parts of the project and check for any breaking changes in the release notes.
47-47: Dependency version updated for@react-aria/interactions.The version has been updated from
3.21.3to3.22.2. It's crucial to verify that this update integrates well with the project, especially since@react-aria/interactionsoften includes functions that might affect component interactions.
48-48: Dependency version updated for@react-aria/utils.The version has been updated from
3.24.1to3.25.2. Check the release notes for any significant changes that might impact the project's stability or functionality.
49-49: Dependency version updated for@react-types/checkbox.The version has been updated from
3.8.1to3.8.3. This update should be checked for compatibility, especially in terms of how it affects checkbox behaviors and properties.packages/components/link/package.json (4)
47-47: Dependency version updated for@react-aria/link.The version has been updated from
3.7.1to3.7.4. Ensure that this update is compatible with other parts of the project and check for any breaking changes in the release notes.
48-48: Dependency version updated for@react-aria/utils.The version has been updated from
3.24.1to3.25.2. It's crucial to verify that this update integrates well with the project, especially since@react-aria/utilsoften includes utility functions that might affect various components.
49-49: Dependency version updated for@react-aria/focus.The version has been updated from
3.17.1to3.18.2. Check the release notes for any significant changes that might impact the project's stability or functionality.
50-50: Dependency version updated for@react-types/link.The version has been updated from
3.5.5to3.5.7. This update should be checked for compatibility, especially in terms of how it affects link behaviors and properties.packages/components/pagination/package.json (4)
48-48: Dependency update approved for@react-aria/i18n.Ensure to verify the integration and functionality with the new version to catch any subtle changes that might affect the component's behavior.
Verification successful
Integration of
@react-aria/i18nconfirmed in pagination component.The
useLocalefunction from@react-aria/i18nis used in the following files:
packages/components/pagination/src/use-pagination.tspackages/components/pagination/src/pagination.tsxEnsure thorough testing to verify that the update to version
3.12.2does not affect the component's functionality.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify integration of @react-aria/i18n in pagination component. # Test: Search for usage of @react-aria/i18n in pagination component. Expect: No errors or warnings. rg --type json -A 5 '@react-aria/i18n' packages/components/pagination/srcLength of output: 73
Script:
#!/bin/bash # Description: Verify integration of @react-aria/i18n in pagination component. # Test: Search for usage of @react-aria/i18n in JavaScript or TypeScript files. rg '@react-aria/i18n' packages/components/pagination --type js --type ts -A 5Length of output: 1174
47-47: Dependency update approved for@react-aria/focus.Ensure to verify the integration and functionality with the new version to catch any subtle changes that might affect the component's behavior.
Verification successful
Integration of
@react-aria/focusconfirmed in pagination component.The
useFocusRingfunction from@react-aria/focusis used inpackages/components/pagination/src/use-pagination-item.ts. Ensure to manually test the functionality related to focus management to confirm that the minor version update does not introduce any issues.
- File:
packages/components/pagination/src/use-pagination-item.ts- Import:
useFocusRingfrom@react-aria/focusScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify integration of @react-aria/focus in pagination component. # Test: Search for usage of @react-aria/focus in pagination component. Expect: No errors or warnings. rg --type json -A 5 '@react-aria/focus' packages/components/pagination/srcLength of output: 74
Script:
#!/bin/bash # Description: Verify integration of @react-aria/focus in pagination component. # Test: Search for usage of @react-aria/focus in JavaScript and TypeScript files within the pagination component. rg '@react-aria/focus' packages/components/pagination --type js --type tsLength of output: 179
49-49: Dependency update approved for@react-aria/interactions.Ensure to verify the integration and functionality with the new version to catch any subtle changes that might affect the component's behavior.
50-50: Dependency update approved for@react-aria/utils.Ensure to verify the integration and functionality with the new version to catch any subtle changes that might affect the component's behavior.
packages/components/button/package.json (5)
50-50: Dependency update approved for@react-aria/interactions.Ensure to verify the integration and functionality with the new version to catch any subtle changes that might affect the component's behavior.
Verification successful
Dependency update verified for
@react-aria/interactions.The
useHoverfunction from@react-aria/interactionsis used inpackages/components/button/src/use-button.ts. Please ensure to manually verify the functionality to confirm that the minor version update does not introduce any unexpected behavior.
- File:
packages/components/button/src/use-button.tsScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify integration of @react-aria/interactions in button component. # Test: Search for usage of @react-aria/interactions in button component. Expect: No errors or warnings. rg --type json -A 5 '@react-aria/interactions' packages/components/button/srcLength of output: 77
Script:
#!/bin/bash # Description: Verify integration of @react-aria/interactions in button component. # Test: Search for usage of @react-aria/interactions in JavaScript or TypeScript files. rg '@react-aria/interactions' packages/components/button/src --type js --type ts -A 5Length of output: 566
52-52: Dependency update approved for@react-aria/focus.Ensure to verify the integration and functionality with the new version to catch any subtle changes that might affect the component's behavior.
54-54: Dependency update approved for@react-types/button.Ensure to verify the integration and functionality with the new version to catch any subtle changes that might affect the component's behavior.
49-49: Dependency update approved for@react-aria/button.Ensure to verify the integration and functionality with the new version to catch any subtle changes that might affect the component's behavior.
51-51: Dependency update approved for@react-aria/utils.Ensure to verify the integration and functionality with the new version to catch any subtle changes that might affect the component's behavior.
Verification successful
Dependency update verified for
@react-aria/utils.The functions
chainandmergePropsfrom@react-aria/utilsare used inpackages/components/button/src/use-button.ts. Ensure to manually verify the integration and functionality with the new version to catch any subtle changes that might affect the component's behavior.
- File:
packages/components/button/src/use-button.tsScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify integration of @react-aria/utils in button component. # Test: Search for usage of @react-aria/utils in button component. Expect: No errors or warnings. rg --type json -A 5 '@react-aria/utils' packages/components/button/srcLength of output: 70
Script:
#!/bin/bash # Description: Verify integration of @react-aria/utils in button component. # Test: Search for usage of @react-aria/utils in JavaScript or TypeScript files. rg '@react-aria/utils' packages/components/button/src --type js --type ts -A 5Length of output: 681
packages/components/input/package.json (7)
51-51: Dependency update approved for@react-stately/utils.Ensure to verify the integration and functionality with the new version to catch any subtle changes that might affect the component's behavior.
50-50: Dependency update approved for@react-aria/utils.Ensure to verify the integration and functionality with the new version to catch any subtle changes that might affect the component's behavior.
Verification successful
Dependency update verified for
@react-aria/utils.The package is used in the following files:
packages/components/input/src/use-input.ts: ImportschainandmergeProps.packages/components/input/src/textarea.tsx: ImportsmergeProps.Ensure to verify the component's functionality with the updated version to catch any subtle changes.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify integration of @react-aria/utils in input component. # Test: Search for usage of @react-aria/utils in input component. Expect: No errors or warnings. rg --type json -A 5 '@react-aria/utils' packages/components/input/srcLength of output: 69
Script:
#!/bin/bash # Description: Verify integration of @react-aria/utils in input component. # Test: Search for usage of @react-aria/utils in JavaScript or TypeScript files within the input component directory. rg '@react-aria/utils' packages/components/input/src --type js --type ts -A 5Length of output: 1066
53-53: Dependency update approved for@react-types/textfield.Ensure to verify the integration and functionality with the new version to catch any subtle changes that might affect the component's behavior.
Verification successful
Dependency update verified for
@react-types/textfield.The
AriaTextFieldPropsfrom@react-types/textfieldis used inpackages/components/input/src/use-input.ts. Ensure to verify the integration and functionality with the new version to catch any subtle changes that might affect the component's behavior.
- File:
packages/components/input/src/use-input.tsScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify integration of @react-types/textfield in input component. # Test: Search for usage of @react-types/textfield in input component. Expect: No errors or warnings. rg --type json -A 5 '@react-types/textfield' packages/components/input/srcLength of output: 74
Script:
#!/bin/bash # Description: Verify integration of @react-types/textfield in input component. # Test: Search for usage of @react-types/textfield in JavaScript or TypeScript files. rg '@react-types/textfield' packages/components/input --type js --type ts -A 5Length of output: 729
48-48: Dependency update approved for@react-aria/interactions.Ensure to verify the integration and functionality with the new version to catch any subtle changes that might affect the component's behavior.
47-47: Dependency update approved for@react-aria/focus.Ensure to verify the integration and functionality with the new version to catch any subtle changes that might affect the component's behavior.
49-49: Dependency update approved for@react-aria/textfield.Ensure to verify the integration and functionality with the new version to catch any subtle changes that might affect the component's behavior.
52-52: Dependency update approved for@react-types/shared.Ensure to verify the integration and functionality with the new version to catch any subtle changes that might affect the component's behavior.
Verification successful
Dependency update approved for
@react-types/shared.The
inputcomponent does not directly use@react-types/shared, so the update is unlikely to affect it directly. However, given the extensive usage in other parts of the codebase, ensure to verify the integration and functionality in those areas to catch any subtle changes that might affect the overall behavior.
- Verify integration in components and utilities where
@react-types/sharedis used.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify integration of @react-types/shared in input component. # Test: Search for usage of @react-types/shared in input component. Expect: No errors or warnings. rg --type json -A 5 '@react-types/shared' packages/components/input/srcLength of output: 71
Script:
#!/bin/bash # Description: Verify integration of @react-types/shared in input component. # Test: Search for usage of @react-types/shared in input component source files. rg '@react-types/shared' packages/components/input/src --type js --type ts -A 5Length of output: 79
Script:
#!/bin/bash # Description: Verify integration of @react-types/shared across the entire repository. # Test: Search for usage of @react-types/shared in the entire codebase. rg '@react-types/shared' --type js --type ts -A 5Length of output: 41558
packages/components/card/package.json (5)
49-49: Dependency update approved for@react-aria/utils.Ensure compatibility with existing components using this library.
48-48: Dependency update approved for@react-aria/focus.Ensure compatibility with existing components using this library.
50-50: Dependency update approved for@react-aria/interactions.Ensure compatibility with existing components using this library.
52-52: No change in dependency version for@react-types/shared.Confirm if this version remains compatible with other updated dependencies.
51-51: Dependency update approved for@react-aria/button.Ensure compatibility with existing components using this library.
packages/core/system/src/provider-context.ts (3)
3-3: Approved import statement forDateValue.The addition of the
DateValueimport is necessary for the updated type definitions inProviderContextProps. This aligns with the changes made to accommodate the new date handling mechanism.
48-48: Approved type change formaxDate.The change from
CalendarDatetoDateValuefor themaxDateproperty aligns with the new requirements from the@react-types/datepickerlibrary. Ensure that this change is compatible with other parts of the codebase that interact withmaxDate.Run the following script to verify the impact of this type change on the rest of the codebase:
41-41: Approved type change forminDate.The change from
CalendarDatetoDateValuefor theminDateproperty is necessary to align with the new requirements from the@react-types/datepickerlibrary. Ensure that this change is compatible with other parts of the codebase that interact withminDate.Run the following script to verify the impact of this type change on the rest of the codebase:
packages/components/menu/package.json (8)
49-49: Dependency update approved for@react-aria/focus.The update from
3.17.1to3.18.2is correctly applied and follows semantic versioning guidelines.
50-50: Dependency update approved for@react-aria/interactions.The update from
3.21.3to3.22.2is correctly applied and adheres to semantic versioning principles.
51-51: Dependency update approved for@react-aria/menu.The update from
3.14.1to3.15.3is correctly applied, ensuring compatibility and possibly introducing enhancements.
52-52: Dependency update approved for@react-aria/utils.The update from
3.24.1to3.25.2follows the expected versioning scheme and should introduce compatible changes.
53-53: Dependency update approved for@react-stately/menu.The update from
3.7.1to3.8.2is correctly applied, aligning with semantic versioning and likely introducing new features or improvements.
54-54: Dependency update approved for@react-stately/tree.The update from
3.8.1to3.8.4is a patch version increment, suggesting minor fixes or optimizations.
55-55: Dependency update approved for@react-types/menu.The update from
3.9.9to3.9.11is correctly applied, indicating minor fixes or updates.
56-56: Dependency update approved for@react-types/shared.The update from
3.23.1to3.24.1is correctly applied and adheres to semantic versioning principles.
| @@ -1,6 +1,6 @@ | |||
| import {DateValue, startOfYear} from "@internationalized/date"; | |||
|
|
|||
| export function getYearRange(start?: DateValue, end?: DateValue): DateValue[] { | |||
| export function getYearRange(start?: DateValue | null, end?: DateValue | null): DateValue[] { | |||
There was a problem hiding this comment.
Approved changes to parameter types in getYearRange.
The modification to accept null values for start and end parameters enhances the function's flexibility and type safety. Ensure that corresponding unit tests are updated or added to cover these new cases.
Would you like me to help by adding test cases for these scenarios?
📝 Description
Updated the version of
react-aria.The details of the changes are documented in the inline comments.
⛳️ Current behavior (updates)
🚀 New behavior
💣 Is this a breaking change (Yes/No):
Yes.
As mentioned in the comment below,
layoutNodecan’t be passed anymore. We could pass it separately, but since it's deprecated, I think it's okay to remove it.https://github.com/nextui-org/nextui/pull/3732/files#r1750342546
📝 Additional Information
July 22, 2024 Release – React Spectrum Releases
Summary by CodeRabbit
New Features
@nextui-org/tablepackage and patch updates for various components, enhancing functionality and stability.react-ariafor improved accessibility features and performance optimizations.Bug Fixes
Documentation
Chores