perf: Avoid updating the folder size if we know the size difference #42597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliushaertl
force-pushed
the
perf/s3-mkdir-update-size
branch
2 times, most recently
from
5da1ccc
to
2257462
Compare
juliushaertl
requested review from
icewind1991,
Altahrim,
a team and
ArtificialOwl
and removed request for
a team
juliushaertl
added
3. to review
juliushaertl
force-pushed
the
perf/s3-mkdir-update-size
branch
from
2257462
to
90fe6b1
Compare
|
Tests passing except for unrelated failure that also happens on master |
Altahrim
approved these changes
Jan 10, 2024
|
Failures seem consistent with this change though I have no idea why those would occur. Will look into |
juliushaertl
force-pushed
the
perf/s3-mkdir-update-size
branch
from
90fe6b1
to
6976f99
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliushaertl
force-pushed
the
perf/s3-mkdir-update-size
branch
from
6976f99
to
cc75294
Compare
come-nc
approved these changes
Jan 23, 2024
Merged
|
/backport to stable28 |
|
/backport to stable27 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using object storage the scanner does not return any results so
correctFolderSizewas always called even for operations where we don't need to update the parent sizes likemkdir.This PR introduces a shortcut to skip this update if we know the size difference for sure so it can be propagated through
server/lib/private/Files/Cache/Updater.php
Line 144 in 7db5bcc