Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(admin_audit): Migrate to non-deprecated IEventDispatcher #39086

Merged
merged 1 commit into from
Jul 5, 2023
Merged

feat(admin_audit): Migrate to non-deprecated IEventDispatcher #39086

merged 1 commit into from
Jul 5, 2023

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jun 30, 2023 •
edited
Loading

One step closer for #38546

Checklist

@nickvergessen nickvergessen added this to the Nextcloud 28 milestone Jun 30, 2023
@nickvergessen nickvergessen requested review from ChristophWurst, come-nc and a team June 30, 2023 10:52
@nickvergessen nickvergessen self-assigned this Jun 30, 2023
@nickvergessen nickvergessen requested review from icewind1991 and blizzz and removed request for a team June 30, 2023 10:52
ChristophWurst
ChristophWurst reviewed Jun 30, 2023
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do the full cleanup :)

apps/admin_audit/lib/AppInfo/Application.php Show resolved Hide resolved
@nickvergessen nickvergessen force-pushed the bugfix/noid/migrate-admin_audit-to-IEventDispatcher branch from 8b20f9c to d1ccd35 Compare June 30, 2023 12:28
@ChristophWurst
Copy link
Member

Autoloader changes are probably caused by a new version of Composer

@nickvergessen nickvergessen mentioned this pull request Jul 3, 2023
Merged
4 tasks
@nickvergessen nickvergessen force-pushed the bugfix/noid/migrate-admin_audit-to-IEventDispatcher branch from a8802fe to 158f080 Compare July 4, 2023 07:33
@nickvergessen
Copy link
Member Author

Rebased after #39089

@nickvergessen
feat(admin_audit): Migrate to non-deprecated IEventDispatcher
eb09053 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/migrate-admin_audit-to-IEventDispatcher branch from 158f080 to eb09053 Compare July 4, 2023 10:36
@blizzz blizzz merged commit c5285d6 into master Jul 5, 2023
38 checks passed
@blizzz blizzz deleted the bugfix/noid/migrate-admin_audit-to-IEventDispatcher branch July 5, 2023 10:05
@nickvergessen nickvergessen mentioned this pull request Jul 6, 2023
Merged
4 tasks
@nickvergessen nickvergessen added the pending documentation This pull request needs an associated documentation update label Jul 27, 2023
@nickvergessen nickvergessen mentioned this pull request Jul 28, 2023
Merged
15 tasks
@nickvergessen
Copy link
Member Author

Docs in nextcloud/documentation#10858

@nickvergessen nickvergessen removed the pending documentation This pull request needs an associated documentation update label Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@miaulalala miaulalala miaulalala approved these changes

@come-nc come-nc come-nc approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend

@blizzz blizzz Awaiting requested review from blizzz blizzz was automatically assigned from nextcloud/server-backend

Assignees

@nickvergessen nickvergessen

Labels
3. to review Waiting for reviews enhancement feature: admin audit
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
5 participants
@nickvergessen @ChristophWurst @miaulalala @come-nc @blizzz