Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable3.7] fix: wrong attendance status for imip events #10090

Merged
merged 2 commits into from
Sep 4, 2024
Merged

[stable3.7] fix: wrong attendance status for imip events #10090

merged 2 commits into from
Sep 4, 2024

Commits on Sep 4, 2024

  1. fix: fetch attendance status when calendars are loaded 

    One may have imported an event, but the attendance status is not properly fetched when rendering the email.
The reason is a timing / state problem.

- Loading the user principal and collections is initialized in https://github.com/nextcloud/mail/blob/6fc45eb0630b9065f9ccb4c1da5cc9557f7df834/src/App.vue#L49-L50.
- If the backend request for the message body is faster, than loading the principal and collections, then Imip.fetchExistingEvent runs without having calendars and changes existingEventFetched to true that prevents the method from running again.
- Solution: Render the imip component when principal and collections are fetched.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
    @kesselb
    kesselb committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    b1d6c90 View commit details
    Browse the repository at this point in the history

  2. perf: skip non-writable calendars 

    Accepting a calendar invitation should always go to a writable calendar, and therefore we can skip the check if the event exists in a read-only calendar.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
    @kesselb
    kesselb committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    d5f6a1e View commit details
    Browse the repository at this point in the history