fix: respect advanced group sharing settings in frontend #4108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st3iny
added
bug
hamza221
approved these changes
Sep 23, 2024
|
/backport to stable6.1 |
|
/backport to stable6.0 |
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
st3iny
force-pushed
the
fix/respect-group-sharing-in-frontend
branch
from
fcceac4
to
5450606
Compare
st3iny
requested review from
SebastianKrupinski and
GVodyanov
as code owners
SebastianKrupinski
approved these changes
Sep 23, 2024
This was referenced Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #1139
The DAV backend seems to ignore the setting though. So I think it is still possible to forge a request via curl and share with a group. That needs to be fixed in server.
Screenshots
Empty search
Searching for a group (with disabled group sharing)