Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Implements automatically setting up nexd proxy ingress/egress rules using skupper config. #1221

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

chirino
Copy link
Member

@chirino chirino commented Jun 25, 2023

To test out the PoC:

  1. get local dev server running using make run-on-kind.
  2. run ./hack/skupper/install-skupper.sh to install skupper. This will bring up a browser to an app which uses skupper's dataplane to connect the frontend app to the backend service.
  3. run ./hack/skupper/replace-with-nexodus.sh to replace the skupper router with a nexodus implementation. This will bring up a browser to an app which uses nexodus dataplane to connect the frontend app to the backend service.
  4. run ./hack/skupper/proxy-status.sh to see the ingress/egress rules that get created on each nexd running in proxy mode.

@netlify
Copy link

netlify bot commented Jun 25, 2023

Deploy Preview for nexodus-docs canceled.

Name Link
🔨 Latest commit 9bb15b5
🔍 Latest deploy log https://app.netlify.com/sites/nexodus-docs/deploys/649dae5b7a69fb0008dbb03a

@mergify mergify bot added missing-docs-label missing has-docs or no-docs-needed missing-design-label missing has-design or no-design-needed label missing-tests-label This PR is missing a tests label, has-tests or no-tests-required labels Jun 25, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 26, 2023

@chirino, this pull request is now in conflict and requires a rebase.

@mergify mergify bot added the needs-rebase label Jun 26, 2023
Signed-off-by: Hiram Chirino <hiram@hiramchirino.com>
Signed-off-by: Hiram Chirino <hiram@hiramchirino.com>
… using a skupper config file.

Signed-off-by: Hiram Chirino <hiram@hiramchirino.com>
… discover service locations.

Signed-off-by: Hiram Chirino <hiram@hiramchirino.com>
…gress proxies get removed.

Signed-off-by: Hiram Chirino <hiram@hiramchirino.com>
…rgeted by services created by the skupper service controller.

Also improved the PoC scripts so that your can fully replace the skupper router
plane with the nexodus router.

Signed-off-by: Hiram Chirino <hiram@hiramchirino.com>

#
# Deploy nexodus proxy routers that will proxy services based on the skupper config:
kubectl config set-context --current --namespace west
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing that bit me was that if you run two separate scripts at the same time that are nothing using kubectl config set-context, they'll break each other. I did that with some performance testing I was doing.

@russellb russellb added the hold PRs that should be held label Jun 28, 2023
@russellb
Copy link
Member

@chirino very cool PoC -- is it posted here for easy discussion and testing? or were you proposing that it be merged? Maybe we should create a new repo for skipper integration. We could run the config controller as a sidecar container in the nexd container that uses either nexctl or the socket interface directly for managing rules.

@chirino
Copy link
Member Author

chirino commented Jun 28, 2023

Yeah. Right now it's here for easy sharing.

We can move this around to a different process if we figure out the final desires architecture.

@russellb russellb marked this pull request as draft June 30, 2023 12:58
@russellb russellb removed missing-docs-label missing has-docs or no-docs-needed missing-design-label missing has-design or no-design-needed label missing-tests-label This PR is missing a tests label, has-tests or no-tests-required labels Jun 30, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 30, 2023

@chirino, this pull request is now in conflict and requires a rebase.

@mergify mergify bot added the needs-rebase label Jun 30, 2023
@chirino chirino changed the title Implements automatically setting up nexd proxy ingress/egress rules using skupper config. WIP: Implements automatically setting up nexd proxy ingress/egress rules using skupper config. Jul 3, 2023
Copy link
Contributor

mergify bot commented Feb 5, 2024

@chirino, this pull request is now in conflict and requires a rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold PRs that should be held needs-rebase
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

2 participants