test: Migrated test/versioned/amqplib to node:test
#2612
+587
−781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bizob2828
force-pushed
the
migrate-amqplib
branch
from
c87beaa
to
94ee7ff
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2612 +/- ##
==========================================
- Coverage 97.23% 97.18% -0.05%
==========================================
Files 291 291
Lines 45941 45941
==========================================
- Hits 44670 44648 -22
- Misses 1271 1293 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bizob2828
force-pushed
the
migrate-amqplib
branch
from
94ee7ff
to
1d0b4e2
Compare
bizob2828
commented
Sep 24, 2024
bizob2828
commented
Sep 24, 2024
bizob2828
force-pushed
the
migrate-amqplib
branch
from
1d0b4e2
to
7306d19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrated amqplib tests to
node:test. I also cleaned up the promise tests and removed the chains and just await promises. I also do most assertions after the test executes to avoid hanging tests. Lastly I added the consume methods, where applicable, to outside the transaction to better mirror a real world use case and simplify the util assertions around segment treesHow to Test
Related Issues
Closes #2611