Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate block of unit tests to node:test #2607

Merged
merged 10 commits into from
Sep 24, 2024

Conversation

jsumners-nr
Copy link
Contributor

This PR resolves #2606.

@jsumners-nr jsumners-nr added the dev:tests Indicates only changes to tests label Sep 23, 2024
@jsumners-nr jsumners-nr marked this pull request as ready for review September 23, 2024 17:34
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.18%. Comparing base (8d1acff) to head (cd41aba).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2607      +/-   ##
==========================================
- Coverage   97.23%   97.18%   -0.05%     
==========================================
  Files         291      291              
  Lines       45941    45941              
==========================================
- Hits        44670    44648      -22     
- Misses       1271     1293      +22     
Flag Coverage Δ
integration-tests-cjs-18.x 74.16% <ø> (ø)
integration-tests-cjs-20.x 74.18% <ø> (ø)
integration-tests-cjs-22.x 74.22% <ø> (ø)
integration-tests-esm-18.x 49.68% <ø> (ø)
integration-tests-esm-20.x 49.68% <ø> (ø)
integration-tests-esm-22.x 49.71% <ø> (ø)
unit-tests-18.x 88.86% <ø> (ø)
unit-tests-20.x 88.86% <ø> (ø)
unit-tests-22.x 88.87% <ø> (ø)
versioned-tests-18.x 78.96% <ø> (-0.19%) ⬇️
versioned-tests-20.x 78.96% <ø> (-0.19%) ⬇️
versioned-tests-22.x 78.97% <ø> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bizob2828 bizob2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsumners-nr jsumners-nr merged commit e33807b into newrelic:main Sep 24, 2024
30 of 31 checks passed
@jsumners-nr jsumners-nr deleted the issue-2606 branch September 24, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev:tests Indicates only changes to tests
Projects
Status: Done: Issues recently completed
Development

Successfully merging this pull request may close these issues.

Migrate unit tests group 5 to node:test
2 participants