Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed handling of Pino merging object #2600

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

jsumners-nr
Copy link
Contributor

This PR resolves #2595.

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.18%. Comparing base (d169546) to head (59151cb).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2600      +/-   ##
==========================================
- Coverage   97.23%   97.18%   -0.05%     
==========================================
  Files         291      291              
  Lines       45932    45940       +8     
==========================================
- Hits        44661    44647      -14     
- Misses       1271     1293      +22     
Flag Coverage Δ
integration-tests-cjs-18.x 74.17% <0.00%> (-0.02%) ⬇️
integration-tests-cjs-20.x 74.18% <0.00%> (-0.02%) ⬇️
integration-tests-cjs-22.x 74.22% <0.00%> (-0.02%) ⬇️
integration-tests-esm-18.x 49.68% <0.00%> (-0.01%) ⬇️
integration-tests-esm-20.x 49.68% <0.00%> (-0.01%) ⬇️
integration-tests-esm-22.x 49.71% <0.00%> (-0.01%) ⬇️
unit-tests-18.x 88.86% <0.00%> (-0.02%) ⬇️
unit-tests-20.x 88.86% <0.00%> (-0.02%) ⬇️
unit-tests-22.x 88.87% <0.00%> (-0.02%) ⬇️
versioned-tests-18.x 78.96% <100.00%> (-0.18%) ⬇️
versioned-tests-20.x 78.96% <100.00%> (-0.18%) ⬇️
versioned-tests-22.x 78.97% <100.00%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsumners-nr jsumners-nr marked this pull request as ready for review September 23, 2024 12:24
@jsumners-nr jsumners-nr merged commit de3c266 into newrelic:main Sep 23, 2024
30 of 31 checks passed
@jsumners-nr jsumners-nr deleted the issue-2595 branch September 23, 2024 12:59
@github-actions github-actions bot mentioned this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done: Issues recently completed
Development

Successfully merging this pull request may close these issues.

newrelic is wiping message object when uses log forwarding with pinohttp
2 participants