ci: Updated codecov action sha to post coverage from forks. Added flag to fail ci if it fails to upload report #2490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bizob2828
force-pushed
the
fork-pr
branch
2 times, most recently
from
2c0e344
to
5d3e4e7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2490 +/- ##
==========================================
- Coverage 96.20% 88.69% -7.51%
==========================================
Files 288 270 -18
Lines 45305 43834 -1471
==========================================
- Hits 43586 38879 -4707
- Misses 1719 4955 +3236
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bizob2828
force-pushed
the
fork-pr
branch
3 times, most recently
from
a60b286
to
a1ffe71
Compare
bizob2828
changed the title
…g to fail ci if it fails to upload report
svetlanabrennan
approved these changes
Aug 19, 2024
jsumners-nr
approved these changes
Aug 19, 2024
Merged
This was referenced Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were pinning the codecov-action to a sha that no longer works for posting coverage on PRs. I also enabled
fail_ci_if_error: trueto fail CI so we can catch issues in the future. This PR won't exercise the upload but I did have a past run that tested it hereHow to Test
Please describe how you have tested these changes. Have you run the code against an example application?
What steps did you take to ensure that the changes are working correctly?
Related Issues
Closes #2485