-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Added benchmark test GitHub Action #2366
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bizob2828
requested changes
Jul 16, 2024
bizob2828
requested changes
Jul 16, 2024
bizob2828
reviewed
Jul 16, 2024
Signed-off-by: mrickard <maurice@mauricerickard.com>
Signed-off-by: mrickard <maurice@mauricerickard.com>
Signed-off-by: mrickard <maurice@mauricerickard.com>
mrickard
force-pushed
the
basic-benchmark-gha
branch
from
July 17, 2024 14:19
0afc49c
to
4912ee6
Compare
bizob2828
approved these changes
Jul 17, 2024
this is not linking to the github issue. please update your PR description |
This was referenced Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added benchmark test GitHub Action, which automatically writes the output to a file in
benchmark_results
. The file is named with the git branch and Node version, which are supplied by the action.How to Test
When this action is run, it verifies that it's written a file to the output by running
ls
on the output directory. File contents aren't inspected, but it's a baseline check that the benchmark test did not fail.Related Issues
Closes #2118
Closes NR-255566