chore: updated isNonWritable to always strict equal

newrelic · Sep 23, 2024 · 9feeaed · 9feeaed
1 parent 27a3432
commit 9feeaed
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/test/lib/custom-assertions.js b/test/lib/custom-assertions.js
@@ -55,21 +55,15 @@ function assertCLMAttrs({ segments, enabled: clmEnabled, skipFull = false }) {
  * @param {string} params.key key to assign value
  * @param {string} params.value expected value of obj[key]
  */
-function isNonWritable({ obj, key, value, complex }) {
+function isNonWritable({ obj, key, value }) {
   assert.throws(function () {
     obj[key] = 'testNonWritable test value'
   }, new RegExp("(read only property '" + key + "'|Cannot set property " + key + ')'))
 
   if (value) {
-    assert.equal(obj[key], value)
-  } else if (complex) {
-    assert.notStrictEqual(
-      obj[key],
-      'testNonWritable test value',
-      'should not set value when non-writable'
-    )
+    assert.strictEqual(obj[key], value)
   } else {
-    assert.notEqual(
+    assert.notStrictEqual(
       obj[key],
       'testNonWritable test value',
       'should not set value when non-writable'

diff --git a/test/unit/shim/shim.test.js b/test/unit/shim/shim.test.js
@@ -190,7 +190,7 @@ test('Shim', async function (t) {
 
     await t.test('should be a non-writable property', function (t) {
       const { shim } = t.nr
-      isNonWritable({ obj: shim, key: 'logger', complex: true })
+      isNonWritable({ obj: shim, key: 'logger' })
     })
 
     await t.test('should be a logger to use with the shim', function (t) {