Avoid edge case where Trainer wraps ReduceLROnPlateau in SequentialLR
#41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aramist
approved these changes
Aug 1, 2023
Aramist
reviewed
Aug 1, 2023
| @@ -259,6 +253,13 @@ def __init_model(self): | |||
| "threshold": scheduler_config.get("PLATEAU_THRESHOLD", 1e-4), | |||
| "min_lr": scheduler_config.get("MIN_LEARNING_RATE", 0), | |||
| } | |||
| if len(scheduler_configs) != 1: | |||
| raise ValueError( | |||
There was a problem hiding this comment.
This condition should probably be moved outside the for loop. I think it will fail to trigger the error here if the reduce on plateau scheduler is listed as the first of many schedulers
There was a problem hiding this comment.
Looks like it might work actually? With lr scheduler config
"SCHEDULERS": [
{
"SCHEDULER_TYPE": "REDUCE_ON_PLATEAU",
"MULTIPLICATIVE_DECAY_FACTOR": 0.5,
"PATIENCE": 2
},
{
"SCHEDULER_TYPE": "COSINE_ANNEALING",
"MIN_LEARNING_RATE": 0.0,
},
]I get the desired error:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #40. Because I messed up when creating the branch, should only be merged after merging #39.