Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sieveCoarseFraction #217

Closed
brownag opened this issue Nov 8, 2021 · 4 comments
Closed

sieveCoarseFraction #217

brownag opened this issue Nov 8, 2021 · 4 comments
Labels
enhancement NASIS-local This tag is used for pull requests, issues, discussions etc. for soilDB local NASIS functions

Comments

@brownag
Copy link
Member

brownag commented Nov 8, 2021 •
edited
Loading

New function to consolidate simplifyFragmentData / simplifyArtifactData into a single routine #135

Things that might be supported:

  • custom input column names (table specific) (mostly already addressed in simplifyFragmentData)
  • alternate sieve sizes (other non-USDA systems?)
  • custom output column names (beyond just prefixes)
  • custom functional summaries and naming
  • custom messages
@brownag
Copy link
Member Author

brownag commented Nov 8, 2021

Related #216, #46

@dylanbeaudette
Copy link
Member

Note to self to make changes to .sieve and .rockFragmentSieve in order to generalize to non-USDA systems.

@brownag brownag mentioned this issue Nov 8, 2021
Open
6 tasks
@brownag brownag added enhancement NASIS-local This tag is used for pull requests, issues, discussions etc. for soilDB local NASIS functions labels Jan 5, 2022
@brownag
Copy link
Member Author

brownag commented May 18, 2022

Made some progress towards this c2f916b

I suggest the lowest-level sieve() function be exported from aqp. We can keep this internal .sieve() until we've got it into the package and on CRAN. The sieves argument is exposed to the user in soilDB at simplifyFragment/ArtifactData()

brownag referenced this issue May 18, 2022
@brownag
Coarse fractions and .sieve: Allow for custom sieves argument
c2f916b 
 - Remove 76mm gravel warning

 - Adjust gravel threshold to 76mm
brownag added a commit to ncss-tech/aqp that referenced this issue Mar 28, 2023
@brownag
Add sieve()
5d063c7 
 - will close ncss-tech/soilDB#217
@brownag brownag mentioned this issue Mar 28, 2023
Merged
@brownag
Copy link
Member Author

brownag commented Mar 28, 2023

I think the main features that were identified in OP have been resolved, and a newsieve() function has been added to a PR (ncss-tech/aqp#283) for inclusion in aqp 2.0.

@brownag brownag closed this as completed Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement NASIS-local This tag is used for pull requests, issues, discussions etc. for soilDB local NASIS functions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dylanbeaudette @brownag