consolidate / merge / coordinate all "flattening" code

[dylanbeaudette]

A reminder to coordinate efforts on related functionality so that there is a single implementation (if possible) and efficient testing.

Updated TODO Jan 2021

• landscape / landform .formatLandformString() needs review #47 NASIS geomorphic feature query has joins without join constraint #48 normalize parent material, geomorp, ecosite, flattening strategies #84
• parent material multiple RV parent material groups results in duplicate coiids via fetchNASIS_components #58, unify methods / assumptions for flattening parent material and geomorphic records #60 normalize parent material, geomorp, ecosite, flattening strategies #84
• ecosite normalize parent material, geomorp, ecosite, flattening strategies #84
• laboratory data / phsample / NCSS Lab Layer add some queries to accommodate the new ncss_pedon_lab_data tables #3, get_hz_data_from_NASIS_db - issues with join to phsample #120
• texture / texture group multiple texture classes per horizon #6, extract multiple textures / horizon from NASIS data #52
• fragments, "sieving" etc. NASIS surface rf summary should use soilDB::simplifyFragmentData() #46, sieveCoarseFraction #217
• ???

Key principles:

• Parity between similar interfaces. finish NASIS component queries and return similar objects as pedon queries #9, test fill argument for fetchNASIS() components, consider adding for pedons  #131
• Protection against spurious duplication. INNER or LEFT joins for component parent material and geomorph data #31, multiple RV component texture group records results in duplicate horizons/logic fail #32, NASIS geomorphic feature query has joins without join constraint #48, multiple RV parent material groups results in duplicate coiids via fetchNASIS_components #58, get_hz_data_from_NASIS_db - issues with join to phsample #120
• Helpful error messages or identifiers of problems; catch "multiple RV" issues with informative error message new functions for common QC of pedon / component data #89

[brownag]

This can become the lead issue for these issues. The Great Flattening.

#3, #6. #9, #31, #32, #46, #47, #48, #52, #58, #60, #84, #120, #131

Most of these are "NASIS local" related but this issue is broader, and some of above mention SDA.

NASIS and SDA interfaces should have parity between functionality, data offerings, format, logic etc. for these types of things.

[brownag]

Also #89 addresses the "coordinate" aspect of the Flattening.

[brownag]

I think that with the exception of the following topics, the core parts of this issue are resolved.

What remains:

• new functions for handling multiple texture, structure groups per layer
• long-awaited, more powerful QC functions