Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [Testing Snapshot] [DO NOT MERGE] GHC 9.2.7 upgrade testing-snapshot diff #47

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

arjunkathuria
Copy link
Member

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

Description

This is a dummy PR for GHC 9.2.7 upgrade changes from the testing-snapshot branch. This is not the final version and is intended as a preview before the final PRs are up. These changes enable the project to be built with GHC 9.2.7 and the upgraded libraries & dependencies.

Most commits should have detailed contextual point-based descriptions of what changed and why with that commit for much more convenient understanding of the changes made with that commit.

Additional Changes

  • This PR modifies the database schema (database migration added)
  • This PR modifies dhall configs/environment variables

Motivation and Context

This was done as part of upgrading the entire mobility set of projects to GHC 9.2.7

How did you test it?

This repo does not have any tests to run. The project compiling and building successfully was thus taken as a proxy for now.
Full ride flow onceover testing and basic sanity testing was done on the nammayatri repo, of which, this is a dependency.

* Since We updated Euler-hs versions, some of the functions it used
  to export are not there anymore.

* Updates the code to reflect the new state of Euler-hs exports.
* ManagerSelector type in an older version of euler used to be a
  type synonym for "Text".

* This is now a newtype with a newtype constructor "ManagerSelector"
  from Euler.Types modules

* Wraps old useages with newtype constructor for correct type.
* The types changed in Aeson2 and beckn-shared-kernel

* Adds unordered-containers package in app/gateway's package.yaml
  to get the "HashMap" container.

* Changes types to "HashMap Text" where needed from "Map String"
…nges

* Removes now redundant imports after making the Aeson2 and
  beckn-shared-kernel changes in the previous commit
* makes "ambiguous-fields" a warning instead of an error.
* Adds the updated .cabal files for beckn-gateway and mock-registry.

* Updates the cabal files with the changes done in package.yaml
  files in the previous commits

* The cabal files were recently commited in the repository and are
  auto-generated by hpack tool, so we need to update them as we go.
* Updates flake.nix file with the following changes
  - update common repo to one that provides GHC 9.2.7 package set
  - updates shared-kernel to one that builds with GHC 9.2.7

* Updates the corresponding flake.lock file with the above changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant