dp_limit and small matrix elements #159
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing now uses numpy 2.0 (which has not yet been released?!) so some tests failed because of that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
The dp_limit that determines the tolerance for near-zero numbers has been lowered to 5e-16, which improves the numerical stability of some equilibria and produces less spurious modes. Additionally, matrix elements are now explicitly set to zero is they are below this limit, which can occur when two equal but opposite numbers get added in a matrix element.
Bugfixes
Legolas
Issues with the
gravito_acoustic,gravito_mhdandinterchange_modesspectra for resolution higher than 50 have now been resolved.Checklist