-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jakarta namespace and Guice 7 #576
Conversation
@sgdesmet Please replace * import usage with direct imports. Also, can you tell me what happened to version 6 of guice? Was that for EE9? For releasing, I'll do one prior to jakartaEE here so its up to date but then will do this after. |
@hazendaz sure, I've removed the wildcard imports. With regards to Guice 6, this was released together with version 7, and is intended as a transition package and as such only partially supports the jakarta namespace :
|
I currently have a project that depends on Google Guice (5.1.0) and org.mybatis:mybatis:3.5.13 Now I have to update Google Guice to 7.0.0 which uses jakarta instead of javax. That, though, makes it incompatible with MyBatis. I have used this pull-request and built 3.19-SNAPSHOT locally.
The rest went smoothly and the application compiled successfully. Unfortunately, I cannot test the whole application, because there are some other incompatibility with other libraries that appear at runtime. But for now, I do not see any problems with MyBatis. |
@sgdesmet I hope to get this released in next week here officially. |
Switch to
jakarta.*
namespaces and Guice 7 (#574).Note that this is a breaking change as the
javax.*
namespaces are no longer supported.Apache Aries was replaced with Agroal + Narayana JTA in the unit tests, as it does not support the jakarta namespace.