initial impl and test
reviewdog [clippy] report
reported by reviewdog 🐶
Findings (2)
framework/base/src/types/managed/basic/big_float.rs|172 col 48| warning: this expression creates a reference which is immediately dereferenced by the compiler
--> framework/base/src/types/managed/basic/big_float.rs:172:48
|
172 | ManagedDecimal::<M, T>::from_big_float(&self, decimals)
| ^^^^^ help: change this to: self
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: #[warn(clippy::needless_borrow)] on by default
framework/base/src/types/managed/basic/big_float.rs|172 col 48| warning: this expression creates a reference which is immediately dereferenced by the compiler
--> framework/base/src/types/managed/basic/big_float.rs:172:48
|
172 | ManagedDecimal::<M, T>::from_big_float(&self, decimals)
| ^^^^^ help: change this to: self
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: #[warn(clippy::needless_borrow)] on by default
Filtered Findings (4)
framework/base/src/storage/mappers/vec_mapper.rs|15 col 33| warning: importing legacy numeric constants
--> framework/base/src/storage/mappers/vec_mapper.rs:15:33
|
15 | use core::{marker::PhantomData, usize};
| ^^^^^
|
= help: remove this import
= note: then usize::<CONST> will resolve to the respective associated constant
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
= note: #[warn(clippy::legacy_numeric_constants)] on by default
framework/base/src/storage/mappers/vec_mapper.rs|15 col 33| warning: importing legacy numeric constants
--> framework/base/src/storage/mappers/vec_mapper.rs:15:33
|
15 | use core::{marker::PhantomData, usize};
| ^^^^^
|
= help: remove this import
= note: then usize::<CONST> will resolve to the respective associated constant
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
= note: #[warn(clippy::legacy_numeric_constants)] on by default
contracts/feature-tests/abi-tester/src/abi_test_type.rs|47 col 12| warning: field field is never read
--> contracts/feature-tests/abi-tester/src/abi_test_type.rs:48:9
|
47 | pub struct ManagedDecimalWrapper<M: ManagedTypeApi> {
| --------------------- field in this struct
48 | pub field: ManagedDecimal<M, ConstDecimals<2>>,
| ^^^^^
|
= note: #[warn(dead_code)] on by default
contracts/feature-tests/abi-tester/src/abi_test_type.rs|47 col 12| warning: field field is never read
--> contracts/feature-tests/abi-tester/src/abi_test_type.rs:48:9
|
47 | pub struct ManagedDecimalWrapper<M: ManagedTypeApi> {
| --------------------- field in this struct
48 | pub field: ManagedDecimal<M, ConstDecimals<2>>,
| ^^^^^
|
= note: #[warn(dead_code)] on by default
Annotations
Check warning on line 172 in framework/base/src/types/managed/basic/big_float.rs
github-actions / clippy
[clippy] framework/base/src/types/managed/basic/big_float.rs#L172
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> framework/base/src/types/managed/basic/big_float.rs:172:48
|
172 | ManagedDecimal::<M, T>::from_big_float(&self, decimals)
| ^^^^^ help: change this to: `self`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by defaultRaw output
framework/base/src/types/managed/basic/big_float.rs:172:48:w:warning: this expression creates a reference which is immediately dereferenced by the compiler
--> framework/base/src/types/managed/basic/big_float.rs:172:48
|
172 | ManagedDecimal::<M, T>::from_big_float(&self, decimals)
| ^^^^^ help: change this to: `self`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
__END__
Check warning on line 172 in framework/base/src/types/managed/basic/big_float.rs
github-actions / clippy
[clippy] framework/base/src/types/managed/basic/big_float.rs#L172
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> framework/base/src/types/managed/basic/big_float.rs:172:48
|
172 | ManagedDecimal::<M, T>::from_big_float(&self, decimals)
| ^^^^^ help: change this to: `self`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by defaultRaw output
framework/base/src/types/managed/basic/big_float.rs:172:48:w:warning: this expression creates a reference which is immediately dereferenced by the compiler
--> framework/base/src/types/managed/basic/big_float.rs:172:48
|
172 | ManagedDecimal::<M, T>::from_big_float(&self, decimals)
| ^^^^^ help: change this to: `self`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
__END__