-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VM refactor: builtin functions #1149
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contract comparison - from 9ece45e to 0b0a251
|
ovstinga
approved these changes
Jul 10, 2023
alyn509
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The builtin functions were previously kept as a list of polymorphic trait objects (
Vec<dyn BuiltinFunction>
). This was not allowing us to have theexecute_lambda
method accept a closure as generic argument, and had us wrap it in a trait object itself (Box<dyn FnOnce() + 'static>
).The problem is that this was imposing us the 'static lifetime bound, which was hurting the usability of the whitebox testing framework.
The solution was to ditch the dynamic dispatch and go for a simple match on the builtin function name. This way we only use static dispatch and handle closures much easier.