bump rand and bip39 in multiverse-sdk #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rupansh
changed the title
andrei-marinica
approved these changes
Jun 15, 2023
|
Hi! Could you perform another merge from master? |
andrei-marinica
approved these changes
Jun 29, 2023
|
Hi! Turns out I didn't notice and more commits entered master. A merge is required again. |
|
merged @andrei-marinica |
andrei-marinica
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the older version of bip39 was causing version conflicts for unicode-normalize for me
also bump rand version.
Note that i switched to
generate_inas we were effectively using the same code and bip39 doesn't support rand 0.8