Merge pull request #1616 from multiversx/stable-toolchain

Stable Rust: GitHub Actions & toolchain
multiversx · May 13, 2024 · 526d319 · 526d319
2 parents fd62fb9 + 8bbca64
commit 526d319
Show file tree

Hide file tree

Showing 11 changed files with 34 additions and 12 deletions.
diff --git a/.github/workflows/actions-nightly.yml b/.github/workflows/actions-nightly.yml
@@ -0,0 +1,25 @@
+name: CI
+
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+  workflow_dispatch:
+
+permissions:
+  checks: write
+  pull-requests: write
+
+jobs:
+  contracts:
+    name: Contracts (nightly)
+    uses: multiversx/mx-sc-actions/.github/workflows/contracts.yml@v3.2.0
+    with:
+      rust-toolchain: nightly-2023-12-11
+      path-to-sc-meta: framework/meta
+      enable-contracts-size-report: false
+      mx-scenario-go-version: v2.1.0-alpha
+      coverage-args: --ignore-filename-regex='meta/src' --ignore-filename-regex='wasm-adapter' --ignore-filename-regex='benchmarks/' --ignore-filename-regex='tests/' --output ./coverage.md
+    secrets:
+      token: ${{ secrets.GITHUB_TOKEN }}
diff --git a/.github/workflows/actions.yml b/.github/workflows/actions.yml
@@ -16,7 +16,7 @@ jobs:
     name: Contracts
     uses: multiversx/mx-sc-actions/.github/workflows/contracts.yml@v3.1.0
     with:
-      rust-toolchain: nightly-2023-12-11
+      rust-toolchain: stable
       path-to-sc-meta: framework/meta
       mx-scenario-go-version: v2.1.0-alpha
       coverage-args: --ignore-filename-regex='meta/src' --ignore-filename-regex='wasm-adapter' --ignore-filename-regex='benchmarks/' --ignore-filename-regex='tests/' --output ./coverage.md

diff --git a/.github/workflows/lldb-formatter-tests.yml b/.github/workflows/lldb-formatter-tests.yml
@@ -16,7 +16,7 @@ jobs:
       - uses: actions-rs/toolchain@v1
         with:
           default: true
-          toolchain: nightly-2023-12-11
+          toolchain: stable
 
       - name: Download vscode-lldb
         uses: robinraju/release-downloader@v1.5

diff --git a/.github/workflows/release-upload.yml b/.github/workflows/release-upload.yml
@@ -20,7 +20,7 @@ jobs:
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
           default: true
-          toolchain: nightly-2023-12-11
+          toolchain: stable
           target: wasm32-unknown-unknown
 
       - name: Setup the PATH variable

diff --git a/.github/workflows/template-test-current.yml b/.github/workflows/template-test-current.yml
@@ -22,7 +22,7 @@ jobs:
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
           default: true
-          toolchain: nightly-2023-12-11
+          toolchain: stable
           target: wasm32-unknown-unknown
 
       - name: Install prerequisites

diff --git a/.github/workflows/template-test-released.yml b/.github/workflows/template-test-released.yml
@@ -22,7 +22,7 @@ jobs:
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
           default: true
-          toolchain: nightly-2023-12-11
+          toolchain: stable
           target: wasm32-unknown-unknown
 
       - name: Install prerequisites

diff --git a/data/codec/tests/derive_struct_with_generic_test.rs b/data/codec/tests/derive_struct_with_generic_test.rs
@@ -9,6 +9,7 @@ use codec::{
 // to test, run the following command in the crate folder:
 // cargo expand --test struct_with_generic_derive_test > expanded.rs
 
+#[allow(dead_code)]
 trait SimpleTrait {
     fn simple_function(&self);
 }

diff --git a/framework/base/src/types/managed/wrapped/managed_address.rs b/framework/base/src/types/managed/wrapped/managed_address.rs
@@ -6,7 +6,6 @@ use crate::{
     codec::{
         DecodeError, DecodeErrorHandler, EncodeErrorHandler, NestedDecode, NestedDecodeInput,
         NestedEncode, NestedEncodeOutput, TopDecode, TopDecodeInput, TopEncode, TopEncodeOutput,
-        TryStaticCast,
     },
     formatter::{hex_util::encode_bytes_as_hex, FormatByteReceiver, SCLowerHex},
     types::{heap::Address, ManagedBuffer, ManagedByteArray, ManagedType},
@@ -200,11 +199,6 @@ where
     }
 }
 
-#[derive(Clone)]
-pub(crate) struct ManagedBufferSizeContext(pub usize);
-
-impl TryStaticCast for ManagedBufferSizeContext {}
-
 impl<M> NestedEncode for ManagedAddress<M>
 where
     M: ManagedTypeApi,

diff --git a/framework/wasm-adapter/src/api/managed_types/static_var_api_node.rs b/framework/wasm-adapter/src/api/managed_types/static_var_api_node.rs
@@ -31,6 +31,7 @@ impl StaticVarApi for VmApiImpl {
 }
 
 impl StaticVarApiImpl for VmApiImpl {
+    #[allow(static_mut_refs)]
     fn with_lockable_static_buffer<R, F: FnOnce(&mut LockableStaticBuffer) -> R>(&self, f: F) -> R {
         unsafe { f(&mut STATIC_BUFFER) }
     }

diff --git a/framework/wasm-adapter/src/lib.rs b/framework/wasm-adapter/src/lib.rs
@@ -1,4 +1,5 @@
 #![no_std]
+#![allow(unknown_lints)]
 
 // Allows us to use alloc::vec::Vec;
 // TODO: get rid of the legacy API and also of this.

diff --git a/rust-toolchain.toml b/rust-toolchain.toml
@@ -1,2 +1,2 @@
 [toolchain]
-channel = "nightly-2023-12-11"
+channel = "stable"