Small improvements on 15 minutes dapp #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Development into main
Development to main
Small StakingV4 fix and xBot Markers update
|
|
||
| The smart contract can only be deployed on the blockchain by an owner, so we will create an owner wallet [here](https://devnet-wallet.multiversx.com). The owner can also update the contract, later on, if needed. | ||
| The smart contract can only be deployed on the blockchain by an owner, so let's create an owner's wallet **PEM file**. The owner can also update the contract, later on, if needed. Keep in mind we only use PEM wallets for testing and playing around with non-production code. For real applications please follow best practices, use secure wallets that can be generated [here](https://wallet.multiversx.com) |
There was a problem hiding this comment.
Full stop at the end of paragraph.
| @@ -242,6 +184,8 @@ All right, let's move on to the application layer. | |||
|
|
|||
| ### **Clone the Sample App** | |||
|
|
|||
| First make sure to go back to the root `ping-pong` folder | |||
There was a problem hiding this comment.
Full stop at end of paragraph.
| @@ -253,41 +197,35 @@ cd dapp | |||
|
|
|||
| ### **Configure the app** | |||
|
|
|||
| Customize the Smart Contract Address | |||
| Use the prefered editor and customize the Smart Contract Address located in `src/config/config-devnet.tsx` | |||
There was a problem hiding this comment.
Typo "preferred".
Colon is missing.
|
|
||
| [comment]: # (mx-context-auto) | ||
|
|
||
| ### **Build the dApp** | ||
|
|
||
| :::important | ||
| [Please make sure you have **yarn installed**](https://classic.yarnpkg.com/lang/en/docs/install/#mac-stable) on your machine. |
There was a problem hiding this comment.
The link contains the segment for mac. Perhaps remove the segment?
schimih
approved these changes
Feb 15, 2024
popenta
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the pull request (what is new / what has changed)
Did you test the changes locally ?
Which category (categories) does this pull request belong to?