Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event log documentation #702

Merged
merged 5 commits into from
Oct 10, 2023
Merged

Event log documentation #702

merged 5 commits into from
Oct 10, 2023

Conversation

miiu96
Copy link
Contributor

@miiu96 miiu96 commented Sep 20, 2023

Description of the pull request (what is new / what has changed)

Did you test the changes locally ?

  • yes
  • no

Which category (categories) does this pull request belong to?

  • document new feature
  • update documentation that is not relevant anymore
  • add examples or more information about a component
  • fix grammar issues
  • other

@bogdan-rosianu bogdan-rosianu marked this pull request as ready for review October 10, 2023 08:58
bogdan-rosianu
bogdan-rosianu previously approved these changes Oct 10, 2023
@mariusmihaic mariusmihaic self-requested a review October 10, 2023 11:38
| Field | Value |
|------------|------------------------------------------------------------------------------------------------------------------------|
| identifier | SCDeploy |
| address | the address of the deploy contract |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| address | the address of the deploy contract |
| address | the address of the deployed contract |

??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

| Field | Value |
|------------|------------------------------------------------------------------------------------------------------------------------|
| identifier | SCUpgrade |
| address | the address of the deploy contract |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| address | the address of the deploy contract |
| address | the address of the deployed contract |

???

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed



:::important Important
Starting from release `rc/v1.6.0`, the `transferValueOnly` will be changed when the flag `ScToScLogEventEnableEpoch` will be enabled.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the rc/v1.6.0 release onward, the transferValueOnly will undergo a modification once the ScToScLogEventEnableEpoch flag is activated as following:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@bogdan-rosianu bogdan-rosianu merged commit 593808e into development Oct 10, 2023
1 check passed
@bogdan-rosianu bogdan-rosianu deleted the event-logs-doc branch October 10, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants