updated contract calls page #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ovidiuolteanu
requested changes
Sep 28, 2023
ovidiuolteanu
requested changes
Sep 28, 2023
ovidiuolteanu
previously requested changes
Sep 28, 2023
wording, typos, clarification Co-authored-by: Ovidiu Olteanu <88948634+ovidiuolteanu@users.noreply.github.com>
ovstinga
previously approved these changes
Oct 2, 2023
CostinCarabas
previously approved these changes
Oct 2, 2023
andrei-marinica
dismissed stale reviews from CostinCarabas and ovstinga
via
5a595cf
ovstinga
previously approved these changes
Oct 2, 2023
CostinCarabas
previously approved these changes
Oct 2, 2023
andrei-marinica
dismissed stale reviews from CostinCarabas and ovstinga
via
deb0e8e
ovstinga
approved these changes
Oct 2, 2023
camilbancioiu
approved these changes
Oct 2, 2023
andrei-marinica
dismissed
ovidiuolteanu’s stale review
changes were addressed and Ovidiu is on vacation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the pull request (what is new / what has changed)
The contract calls needed to be brought up to date and explained in greater detail.
Also noticed we had no documentation on
#[payable(...)]and direct transfers. I had to write it.Testing framework docs are not in scope, will come in next PR.
Did you test the changes locally ?
Which category (categories) does this pull request belong to?