-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Indexer service #689
Indexer service #689
Conversation
docs/sdk-and-tools/elastic-search.md
Outdated
### Option 2 | ||
|
||
:::warning | ||
this Option will be removed on the release `rc/v1.7.0` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are not really sure about this now, maybe state this as:
we plan to remove this option in the release `rc/v1.7.0`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed
docs/sdk-and-tools/indexer.md
Outdated
|
||
In the observer node's configuration directory, `external.toml` config file can be configured | ||
to enable host driver config. The config file can be found | ||
[here](https://github.com/multiversx/mx-chain-go/blob/master/cmd/node/config/external.toml). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this link does not work (yet):
use this one?
https://github.com/multiversx/mx-chain-go/blob/rc/v1.6.0/cmd/node/config/external.toml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed the link
docs/sdk-and-tools/indexer.md
Outdated
|
||
## Overview | ||
|
||
A MultiversX observer node can send messages over `WebSocket` to an elastic indexer service, which will process and index the data in an Elasticsearch database. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a statement here that this feature will work starting from rc/v1.6.0 version of the node?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- what @iulianpascalau mentioned
docs/sdk-and-tools/indexer.md
Outdated
|
||
The supported config variables are as follows: | ||
|
||
- `Enabled`: signals whether a driver should be attached when launching the node. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should remove these lines, since you already reference the config and added it below with extra comments (otherwise we are just duplicating the same info). OR merge the relevant info from both into a single one
Also, we should change MarshallerType
description in https://github.com/multiversx/mx-chain-go/blob/rc/v1.6.0/cmd/node/config/external.toml, since we already support gogo proto messages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
docs/sdk-and-tools/indexer.md
Outdated
In the `elasticindexer` configuration directory (`cmd/elasticindexer/config`), there is the `prefs.toml` | ||
file that can be used to configure the service. | ||
|
||
The supported config variables for web-socket section are: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
docs/sdk-and-tools/indexer.md
Outdated
acknowledge-timeout-in-seconds = 50 | ||
``` | ||
|
||
The supported config variables for the `elastic-cluster` section: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
Description of the pull request (what is new / what has changed)
Documentation how to use the
elasticindexer
serviceDid you test the changes locally ?
Which category (categories) does this pull request belong to?