This repository has been archived by the owner on Feb 26, 2021. It is now read-only.
Fixes #1800 add speech telemetry #1894
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So this will require:
Added in this commit: ianb/mozilla-pipeline-schemas@75f5718 I'll wait for this PR to complete before submitting the change to mozilla-pipeline-schemas (also voiceSchema.js should be updated) |
ianb
reviewed
Aug 10, 2020
| @@ -337,6 +337,10 @@ export const PopupController = function() { | |||
| utterance.onend = () => { | |||
| closePopup(2000); | |||
There was a problem hiding this comment.
Let's add outputSpokenCompleted (true) to this method
|
We should also include speech input locale in telemetry |
andrenatal
force-pushed
the
master
branch
3 times, most recently
from
7ad02c2
to
0ec2a05
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.