Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Pytest log in color in Github Action #739

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

eitanturok
Copy link
Contributor

Currently, running pytest locally generates logs in color. But in Github Actions (GA), the logs are only in white. And it does not look so nice. Adding the flag

 --color=yes

causes pytest to log in color and makes things look nice again. This improves visibility and makes it easier on the eyes to see when tests fail/succeed.

I tested this flag on my fork of MegaBlocks but it should be the same here.

Without:
Here is a GA without the --color=yes flag:

without_color

With:
Here is a GA with the --color=yes flag:

with_color

Copy link
Collaborator

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some fuego

@eitanturok eitanturok merged commit 54b6801 into mosaicml:main Jul 30, 2024
7 checks passed
@eitanturok eitanturok deleted the color-log-ga branch July 30, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants