Adds support for primitive arrays via docblocks (#9)

morrislaptop · Nov 1, 2023 · 6672e9d · 6672e9d
1 parent 94d1352
commit 6672e9d
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 15 deletions.
diff --git a/src/PropertyFactory.php b/src/PropertyFactory.php
@@ -95,13 +95,18 @@ protected function extractDocBlockType(ReflectionProperty $property): ?string
                  * @psalm-suppress RedundantCondition
                  */
                 if (method_exists($type, 'getCollectionValueTypes')) {
-                    $collectionType = $type->getCollectionValueTypes()[0];
+                    $collectionType = $type->getCollectionValueTypes()[0] ?? null;
                 } else {
                     /**
                      * @psalm-suppress UndefinedMethod
                      */
                     $collectionType = $type->getCollectionValueType();
                 }
+
+                if (! $collectionType) {
+                    return 'array';
+                }
+
                 $className = $collectionType->getClassName() ?? $collectionType->getBuiltinType();
 
                 return $className . '[]';
@@ -118,6 +123,31 @@ protected function extractDocBlockType(ReflectionProperty $property): ?string
      */
     protected function createPropertyOfType(string $type)
     {
+        switch ($type) {
+            case 'array':
+                return FakerMap::faker()->words();
+
+            case 'bool':
+                return FakerMap::faker()->boolean();
+            case 'bool[]':
+                return [FakerMap::faker()->boolean()];
+
+            case 'int':
+                return FakerMap::faker()->randomDigit();
+            case 'int[]':
+                return [FakerMap::faker()->randomDigit()];
+
+            case 'float':
+                return FakerMap::faker()->randomFloat();
+            case 'float[]':
+                return [FakerMap::faker()->randomFloat()];
+
+            case 'string':
+                return FakerMap::faker()->word();
+            case 'string[]':
+                return FakerMap::faker()->words();
+        }
+
         // Handles an array of DTOs
         if (strpos($type, '[]') !== false) {
             $type = str_replace('[]', '', $type);
@@ -133,20 +163,6 @@ protected function createPropertyOfType(string $type)
                 ->make();
         }
 
-        switch ($type) {
-            case 'array':
-                return FakerMap::faker()->words();
-
-            case 'bool':
-                return FakerMap::faker()->boolean();
-
-            case 'int':
-                return FakerMap::faker()->randomDigit();
-
-            case 'float':
-                return FakerMap::faker()->randomFloat();
-        }
-
         return FakerMap::faker()->word();
     }
 

diff --git a/tests/Popos/PersonData.php b/tests/Popos/PersonData.php
@@ -9,6 +9,10 @@ class PersonData
     public function __construct(
         public $firstName,
         public string $lastName,
+        /** @var array<string,mixed> */
+        public array $otherNames,
+        /** @var array<string,int> */
+        public array $luckyNumbers,
         public string $email,
         public string $homeAddress,
         public ?string $companyName,