refactor: move isAction to compass-utils #6268
Conversation
| export type { AmpersandMethodOptions } from './promisify-ampersand-method'; | ||
| export { promisifyAmpersandMethod } from './promisify-ampersand-method'; |
There was a problem hiding this comment.
drive-by: we are not using these anywhere, so cleaned it up
| [extraProps: string]: any; | ||
| } | ||
|
|
||
| export function isAction<A extends AnyAction>( |
There was a problem hiding this comment.
or should i rename it to isReduxAction?
| ): action is A { | ||
| return action.type === type; | ||
| } | ||
| import { throwIfAborted, isAction } from '@mongodb-js/compass-utils'; |
There was a problem hiding this comment.
It's a good thing to do in general (we should also consider moving some type helpers for redux in the same place), but compass-utils has a dependency on electron and by moving this very generic dependency here you are adding electron to a dependency chain of all plugins that will use it, so we should either have it exported under a different named export to separate the code by imports (this might be good to do for this async helpers anyway), have electron and electron/remote as optional peer deps instead of direct deps and account for this in code, have a completely separate package for these redux helpers
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes