fix(connection-form): vscode support & cleanup COMPASS-8098

[paula-stacho]

Description

Preparing the new connection form for VSCode.
New preferences to be set in VSCode:

saveAndConnectLabel: 'Save & Connect', 
showHelpCardsInForm: false,
showPersonalisationForm: false,

I also used this opportunity to do a bit of cleanup of the pre-MC code (tbh tiptoing around the legacy parts of connection form has been something that bugged me for a while).

Left out (changes that will be visible in VSCode - let me know if you think these should also be customizable so that we avoid them in VSCode):

• the new subtitle 'Manage your connection settings'
• horizontal line above the buttons

Checklist

• New tests and/or benchmarks are included
• Documentation is changed or added
• I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

• Bugfix
• New feature
• Dependency update
• Misc

Open Questions

Dependents

Types of changes

• Backport Needed
• Patch (non-breaking change which fixes an issue)
• Minor (non-breaking change which adds functionality)
• Major (fix or feature that would cause existing functionality to change)

[gribnoysup]

If we're making it impossible to use single connection mode by removing the form, why are we keeping this code here?

[paula-stacho]

I have reverted this bit and will be only removing the tests here. as much as I'd love to follow this rabbit hole, I don't have time to do that, so I'll leave it for the scheduled MC cleanup. I hope the partial cleanup I've done in the connection-form is okay. This is why I was asking in the channel if it's safe to say we won't be reverting the MC flag.

[gribnoysup]

I think the intention for these preferences was only to map compass preferences to connection form without the need to have a dependency on the preferences model (although @mcasimir might correct me on that), this is just something that you'd usually pass as a component property, doesn't feel like it belongs here

[paula-stacho]

Hmm.. I put it there because 'showFavoriteActions' was already there. There is a note above that says '// Not all of these preference map to Compass preferences.', which suggests that what you say used to be true, but at this point maybe we can keep the form preferences together?

[gribnoysup]

If we're already diverging from React patterns in an unconventional ways here and don't want to touch this particular part, I guess it's okay to keep it for now like that for consistency, but just want to make sure we all understand that we are leaving more clean up to do after a "clean up" PR here.

My main concern here is that we are copying patterns in compass codebase often from one place to another (which is totally normal), so leaving code like that is always a risk that antipatterns will start spreading through other parts of the codebase