Clear the worker status when reusing cleaned worker #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm missing something here, converting to draft. |
|
So it seems that the missing part was #269. Ready for review now. |
jajik
force-pushed
the
clear-status
branch
4 times, most recently
from
fd4ccb1
to
6f59f9e
Compare
jfclere
approved these changes
Aug 28, 2024
|
Thanks for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current behaviour is suspicious. The call to
ap_proxy_initialize_workerhas basically no effect and without this change the connection to backend fails from time to time (when running perf tests with dynamic worker removal) which causesall workers in error state(= 503) even though a corresponding node to the worker is up and running.