feat: Simplify Containerfile
#428
Open
+24
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, our `Containerfile` would try to build the project as it exists in the currently checked-out local repo, and package that up. This provided some complexity for publication of new versions, as publishing container images is the _last_ step of our release process, and we _have_ seen instances where all prior steps succeeded and a release is now "out" but the container build failed, and so publication to Docker Hub failed as well. This commit changes the logic of the `Containerfile` to instead just install a prebuilt binary from our GitHub Releases install script. This means we don't worry about building Hipcheck inside of the container. Signed-off-by: Andrew Lilley Brinker <alilleybrinker@gmail.com>
The `Containerfile` is really for users of Hipcheck who want to use it inside a container, and _not_ for the developers of the project, so this commit moves it into the `dist/` folder, and updates references to it elsewhere in the project to reflect the new path. Signed-off-by: Andrew Lilley Brinker <alilleybrinker@gmail.com>
alilleybrinker
added
the
product: release-flow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the project's
Containerfileand moves it into thedist/folder.Check the individual commits for more info. I recommend not squashing prior to merge.