-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude courses which have the download button disabled from mirror drives #2282
base: master
Are you sure you want to change the base?
Exclude courses which have the download button disabled from mirror drives #2282
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please update the testing steps pertaining to local testing with mass build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the changes using upsert_mass_build_pipeline --offline
and I can confirm that the courses are excluded from offline mass build that have download button disabled.
I also confirmed that they are excluded only from offline mass build, not the online one.
Looks good to me.
Where can I find a description about how this works? We have a goal of keeping studio indifferent to the project's data schema, and I feel like we're mixing things up here. For example, if we had a project without a "show download" field, will this api still work? |
Yes, it should be alright. It'd return an empty list instead of raising an error if the |
@pdpinch I did suggest this solution, but yea now that you mention it this does go against our philosophy of not adding any application code to |
Could we modify the code in the mass build script instead of the code in Studio? For example, exiting the build early if the download condition isn't met?
Or, another option, could be build something else in this case, instead of the site? Maybe a page with a link?
|
The mass build pipeline is generated by If we do nothing with the @umar8hassan The only thing I might add to this from a code review perspective is that we will also need to do this in |
…ot downloadable sites
86665de
to
63b241a
Compare
What are the relevant tickets?
closes https://github.com/mitodl/hq/issues/4473
Description (What does it do?)
This excludes the sites in offline mass build which has
hide_download
button set for them.How can this be tested?
main
branch inocw-studio
localhost:8043/sites
or use existing onehide_download
toTrue
docker-compose exec web ./manage.py mass_publish <live/draft> --filter <site-name>
and wait for the build to complete successfully.minio
console atlocalhost:9001
and check course data inocw-content-offline-<live/draft>-local/courses/<site-name>
for your site.umar/4473-exclude-courses-which-have-the-download-button-disabled-from-mirror-drives
inocw-studio
2 - 6
and data should not be updated foroffline
version sites.