ScratchpadにUIインスペクターを追加 #14565
Merged
ScratchpadにUIインスペクターを追加 #14565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #14565 +/- ##
===========================================
+ Coverage 19.54% 19.72% +0.17%
===========================================
Files 713 713
Lines 100312 100375 +63
Branches 997 995 -2
===========================================
+ Hits 19610 19802 +192
+ Misses 80158 80031 -127
+ Partials 544 542 -2 ☔ View full report in Codecov by Sentry. |
|
名称はinspectorで良さそう |
UI inspectorとかではなくてinspector単体でいいですか？ |
|
UI Inspectorで良さそう |
syuilo
reviewed
Sep 17, 2024
syuilo
reviewed
Sep 17, 2024
| <MkContainer :foldable="true" :expanded="false"> | ||
| <template #header>{{ i18n.ts.uiInspector }}</template> | ||
| <div :class="$style.uiInspector"> | ||
| <div v-for="(c, i) in components" :key="i"> |
There was a problem hiding this comment.
Suggested change
| <div v-for="(c, i) in components" :key="i"> | |
| <div v-for="c in components"> |
There was a problem hiding this comment.
v-forを使うならkeyはとりあえずつけておいた方がいいみたいなイメージがありますが、今回は不要なのですか？
There was a problem hiding this comment.
インデックスをkeyとして使うのはアンチパターンで、それ使うなら無い方がマシという感じ
There was a problem hiding this comment.
なるほど、言われてみればインデックスをkeyにすると結局値との対応関係が保たれないですね
c.value.idではどうですか？
Co-authored-by: syuilo <4439005+syuilo@users.noreply.github.com>
|
👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
サンプル映像
「UIインスペクター」から、実行中のスクリプトで生成されたUIコンポーネントのインスタンスの一覧、およびそれらのプロパティを見ることができるようにします。
Why
Misskey Aiscript UIのデバッグは情報を得る手段が少なく難易度が高いため、ある程度補助があった方がよいと考えたため。
Additional info (optional)
Checklist