Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): MkRangeのタッチ操作時にtooltipが複数重なって表示されないように #14548

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Sep 14, 2024

What

v-tooltipとos.popupの両方でツールチップを呼び出していたため、os.popup側だけに寄せた
Cherry-picked from taiyme#265

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@kakkokari-gtyih kakkokari-gtyih changed the title fix: MkRangeのタッチ操作時にtooltipが複数重なって表示されないように fix(frontend): MkRangeのタッチ操作時にtooltipが複数重なって表示されないように Sep 14, 2024
@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Sep 14, 2024
Copy link

codecov bot commented Sep 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 45 lines in your changes missing coverage. Please review.

Project coverage is 19.71%. Comparing base (1544ba9) to head (1af9833).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/components/MkRange.vue 0.00% 45 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14548      +/-   ##
===========================================
+ Coverage    19.53%   19.71%   +0.18%     
===========================================
  Files          713      713              
  Lines       100293   100329      +36     
  Branches       997      995       -2     
===========================================
+ Hits         19591    19781     +190     
+ Misses       80158    80006     -152     
+ Partials       544      542       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo
Copy link
Member

syuilo commented Sep 15, 2024

これだとマウスオーバーしたときに表示されなくならない?

@kakkokari-gtyih
Copy link
Contributor Author

これだとマウスオーバーしたときに表示されなくならない?

ホバー時にも出るようにした

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

タッチ操作でスライダの吹き出し表示が2重になる
3 participants