Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend/frontend-embed): インポートパス・テーマまわりなどの修正 #14535

Merged
merged 5 commits into from
Sep 10, 2024

Conversation

kakkokari-gtyih
Copy link
Contributor

What

  • frontend: テーマのインポートパスの変更漏れを修正
  • frontend-embed: iframeを正常に透過させるためにCSSのcolor-schemeをlight darkに固定
  • frontend-embed: 一部のconsoleをDEVのみで表示させるように修正
  • frontend-embed: サーバーデフォルトのテーマがある場合はそちらを利用するように

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 19.76%. Comparing base (2cbe1d1) to head (1dc18fc).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...s/frontend/src/components/MkEmbedCodeGenDialog.vue 0.00% 1 Missing ⚠️
packages/frontend/src/scripts/theme.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14535       +/-   ##
============================================
- Coverage    41.37%   19.76%   -21.61%     
============================================
  Files         1543      717      -826     
  Lines       196679   100466    -96213     
  Branches      3547     1003     -2544     
============================================
- Hits         81371    19859    -61512     
+ Misses      114714    80063    -34651     
+ Partials       594      544       -50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih kakkokari-gtyih added this to the v2024.9.0 milestone Sep 10, 2024
@syuilo syuilo merged commit f393b6b into misskey-dev:develop Sep 10, 2024
20 checks passed
@syuilo
Copy link
Member

syuilo commented Sep 10, 2024

🙏🏿

@kakkokari-gtyih kakkokari-gtyih deleted the fix-embed-missing-bits-1 branch September 10, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants