Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend/antenna): キーワードが与えられなかった場合のエラーをApiErrorとして投げる #14491

Conversation

KisaragiEffective
Copy link
Collaborator

@KisaragiEffective KisaragiEffective commented Sep 4, 2024

What

題名通り

Why

close #14492

Additional info (optional)

n/a

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/backend Server side specific issue/PR packages/backend:test labels Sep 4, 2024
Copy link
Contributor

github-actions bot commented Sep 4, 2024

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -17260,6 +17260,15 @@
                       }
                     }
                   },
+                  "EMPTY_KEYWORD": {
+                    "value": {
+                      "error": {
+                        "message": "Either keywords or excludeKeywords is required.",
+                        "code": "EMPTY_KEYWORD",
+                        "id": "53ee222e-1ddd-4f9a-92e5-9fb82ddb463a"
+                      }
+                    }
+                  },
                   "INVALID_PARAM": {
                     "value": {
                       "error": {
@@ -18145,6 +18154,15 @@
                       }
                     }
                   },
+                  "EMPTY_KEYWORD": {
+                    "value": {
+                      "error": {
+                        "message": "Either keywords or excludeKeywords is required.",
+                        "code": "EMPTY_KEYWORD",
+                        "id": "721aaff6-4e1b-4d88-8de6-877fae9f68c4"
+                      }
+                    }
+                  },
                   "INVALID_PARAM": {
                     "value": {
                       "error": {

Get diff files from Workflow Page

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 39.52%. Comparing base (1544ba9) to head (86f3302).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...ackend/src/server/api/endpoints/antennas/create.ts 85.71% 1 Missing ⚠️
...ackend/src/server/api/endpoints/antennas/update.ts 85.71% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14491       +/-   ##
============================================
+ Coverage    19.53%   39.52%   +19.99%     
============================================
  Files          713     1535      +822     
  Lines       100293   190834    +90541     
  Branches       997     3498     +2501     
============================================
+ Hits         19591    75433    +55842     
- Misses       80158   114807    +34649     
- Partials       544      594       +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samunohito
Copy link
Member

/preview

@samunohito
Copy link
Member

出た
image

@KisaragiEffective KisaragiEffective changed the title fix(backend/antenna): 更新時にキーワードが与えられなかった場合のエラーをApiErrorとして投げる fix(backend/antenna): にキーワードが与えられなかった場合のエラーをApiErrorとして投げる Sep 5, 2024
@KisaragiEffective KisaragiEffective changed the title fix(backend/antenna): にキーワードが与えられなかった場合のエラーをApiErrorとして投げる fix(backend/antenna): キーワードが与えられなかった場合のエラーをApiErrorとして投げる Sep 5, 2024
@KisaragiEffective

This comment was marked as resolved.

@samunohito

This comment was marked as resolved.

@KisaragiEffective
Copy link
Collaborator Author

done in 24eb394

@samunohito
Copy link
Member

(疲労困憊なので明日になったら内容確認します)

@KisaragiEffective
Copy link
Collaborator Author

元のissueは緊急度が低い案件なのでご都合の良いときで良いです

@syuilo syuilo merged commit 6b2072f into misskey-dev:develop Sep 15, 2024
17 checks passed
@syuilo
Copy link
Member

syuilo commented Sep 15, 2024

🙏🏿

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend:test packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

アンテナの更新時にキーワードを与えないと内部エラーが報告される
3 participants